Skip to content

[Core] Retrofit JsonFormatter on gherkin messages #1941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 10, 2020
Merged

[Core] Retrofit JsonFormatter on gherkin messages #1941

merged 8 commits into from
Apr 10, 2020

Conversation

mpkorstanje
Copy link
Contributor

@mpkorstanje mpkorstanje commented Apr 10, 2020 •
edited
Loading

Turns out it is easier then I thought. Lets us delete gherkin-vintage all together.

Also found a bug in gherkin-messages. It doesn't handle backgrounds properly.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.

@mpkorstanje mpkorstanje marked this pull request as ready for review April 10, 2020 13:47
@aslakhellesoy
Copy link
Contributor

Oh that's nice! Bye bye gherkin-vintage :-)

@mpkorstanje mpkorstanje merged commit 5e71c01 into v6.x.x Apr 10, 2020
@mpkorstanje mpkorstanje deleted the retrofix-json-formatter-on-gherking-messages branch April 10, 2020 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mpkorstanje @aslakhellesoy