Skip to content

Update creta-meta.version to v2.0.2 #2110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2020
Merged

Update creta-meta.version to v2.0.2 #2110

merged 2 commits into from
Sep 4, 2020

Conversation

vincent-psarga
Copy link
Contributor

This follows cucumber#1168
There is a security issue involved which was fixed by cucumber-ruby-meta 2.0.2, this change ensures we use the fixed version.

@coveralls
Copy link

coveralls commented Sep 4, 2020

Coverage Status

Coverage remained the same at 86.163% when pulling 0db1f64 on upgrade-create-meta into 47e27a7 on main.

Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. But for future changes, might be good to limit the change strictly to the version numbers and put the boyscouting in a separate commit and PR.

@vincent-psarga
Copy link
Contributor Author

Yes my editor removes leading spaces automatically, I did not really mean to commit that but it seemed to long to put them back :D

@mpkorstanje
Copy link
Contributor

The trick you can apply there is to roll back the additions you made. And only commit the stuff your editor did. Then add your additions on the next commit and PR.

@mpkorstanje mpkorstanje changed the title Update creta-meta to 2.0.2 Upgrade creta-meta to v2.0.2 Sep 4, 2020
@mpkorstanje mpkorstanje changed the title Upgrade creta-meta to v2.0.2 Upgrade create-meta.version to v2.0.2 Sep 4, 2020
@mpkorstanje mpkorstanje changed the title Upgrade create-meta.version to v2.0.2 Update creta-meta.version to v2.0.2 Sep 4, 2020
@mpkorstanje mpkorstanje merged commit eae8b90 into main Sep 4, 2020
@mpkorstanje mpkorstanje deleted the upgrade-create-meta branch September 4, 2020 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants