[JUnit Platform] Support discovery selectors with FilePosition #2121
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpkorstanje
force-pushed
the
junit-platform-select-lines
branch
from
43facec to
f800c60
Compare
|
Wow amazing! |
mpkorstanje
force-pushed
the
junit-platform-select-lines
branch
6 times, most recently
from
560676b to
b3e18b5
Compare
There was no good way to discover and execute a single test when using a file based test system like Cucumber. Recently JUnit added support for file position in the `FileSelector` and `ClasspathResourceSelector`. See: junit-team/junit5#2146 This implements a filter that prunes all scenarios that do not match the `FilePosition` from the discovery selector. This feature itself is not new. It was already implemented for the `UriSelector`.
mpkorstanje
force-pushed
the
junit-platform-select-lines
branch
from
b3e18b5 to
00dbbd4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was no good way to discover and execute a single test when using a file
based test system like Cucumber. Recently JUnit added support for file position
in the
FileSelectorandClasspathResourceSelector.See: junit-team/junit5#2146
This implements a filter that prunes all scenarios that do not match the
FilePositionfrom the discovery selector. This feature itself is not new. Itwas already implemented for the
UriSelector.This feature will benefit the implementation of IDEA-227508. If you would like to use this feature in the future please up up-vote it.
TODO: