[Core] Synchronize event bus before use #2358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can not exclude the possibility that an event is published to the event bus after test execution has completed. For example because the test framework may have decided that a test case has timed out and is now terminating test execution. As such events from the pending testcase on the synchronized bus may race with the events from the unsynchronized bus. This in turn may break the `LinkedList` in the `CanonicalOrderEventPublisher`. Fixes: #2288 (mabye??)
mpkorstanje
force-pushed
the
synchronize-event-bus-before-use
branch
from
aca1759 to
5687ee9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can not exclude the possibility that an event is published to the event bus
after test execution has completed. For example because the test framework may
have decided that a test case has timed out and is now terminating test
execution.
As such events from the pending testcase on the synchronized bus may race with
the events from the unsynchronized bus. This in turn may break the
LinkedListin the
CanonicalOrderEventPublisher.Fixes: #2288 (mabye??)