Skip to content

Use Github release automation #2500

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 19, 2022
Merged

Use Github release automation #2500

merged 6 commits into from
Mar 19, 2022

Conversation

mattwynne
Copy link
Member

🤔 What's changed?

  • Added workflows to release to sonatype and create a GitHub release on push to a release/* branch
  • Updated release docs
  • Modified Makefile to no longer use docker or keybase secrets, and push to release branch instead.

⚡️ What's your motivation?

Run releases transparently using GitHub actions.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, docuemntation etc. without changing behaviour)

♻️ Anything particular you want feedback on?

I'm curious whether we need to do anything about the -P-examples -P-compatibility switches which were previously being sent to the mvn deploy command. I've not reflected those in the maven-profiles argument, but should I? What does the - prefix mean?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@codecov
Copy link

codecov bot commented Mar 17, 2022

Codecov Report

Merging #2500 (83fd4a8) into main (42b4251) will not change coverage.
The diff coverage is n/a.

❗ Current head 83fd4a8 differs from pull request most recent head 12f34f6. Consider uploading reports for the commit 12f34f6 to get more accurate results

@@            Coverage Diff            @@
##               main    #2500   +/-   ##
=========================================
  Coverage     83.76%   83.76%           
  Complexity     2688     2688           
=========================================
  Files           319      319           
  Lines          9471     9471           
  Branches        917      917           
=========================================
  Hits           7933     7933           
  Misses         1201     1201           
  Partials        337      337           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 42b4251...12f34f6. Read the comment docs.

@mattwynne
Copy link
Member Author

OK the Release environment is all set up - I think we should be able to run this whenever you're ready @mpkorstanje

@mattwynne mattwynne requested a review from mpkorstanje March 17, 2022 03:17
@mattwynne mattwynne force-pushed the release-automation branch from c40554c to 2b28371 Compare March 17, 2022 16:05
This is only neccesary to test this piece of infrastructure and should be reverted before the PR is merged.
@mattwynne mattwynne force-pushed the release-automation branch from 83fd4a8 to abdd854 Compare March 17, 2022 16:13
@mpkorstanje mpkorstanje changed the title Release automation Use Github release automation Mar 19, 2022
@mpkorstanje mpkorstanje merged commit a725cdb into main Mar 19, 2022
@mpkorstanje mpkorstanje deleted the release-automation branch March 19, 2022 23:40
mpkorstanje added a commit that referenced this pull request Mar 19, 2022
@mpkorstanje
Copy link
Contributor

@mpkorstanje
Copy link
Contributor

Branch protection rules were missing.

mpkorstanje added a commit that referenced this pull request Mar 20, 2022

publish-mvn:
name: Publish Maven Package
needs: [pre-release-check, test-java]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have referenced test, not test-java.

mpkorstanje added a commit that referenced this pull request Mar 20, 2022
@mpkorstanje
Copy link
Contributor

@mpkorstanje
Copy link
Contributor

Nope.

2022-03-20T00:58:58.2939863Z �[36;1m***�[0m
2022-03-20T00:58:58.2941620Z �[36;1m	***" | gpg --batch --import --no-tty�[0m
2022-03-20T00:58:58.2942282Z �[36;1mecho "hello world" > temp.txt�[0m
2022-03-20T00:58:58.2942920Z �[36;1mgpg --detach-sig \�[0m
2022-03-20T00:58:58.2943508Z �[36;1m  --yes -v \�[0m
2022-03-20T00:58:58.2944114Z �[36;1m  --output=/dev/null \�[0m
2022-03-20T00:58:58.2944759Z �[36;1m  --pinentry-mode loopback \�[0m
2022-03-20T00:58:58.2945465Z �[36;1m  --passphrase "***" temp.txt�[0m
2022-03-20T00:58:58.2946093Z �[36;1mrm temp.txt�[0m
2022-03-20T00:58:58.3004380Z shell: /usr/bin/bash --noprofile --norc -e -o pipefail {0}
2022-03-20T00:58:58.3005068Z env:
2022-03-20T00:58:58.3005753Z   JAVA_HOME: /opt/hostedtoolcache/Java_Temurin-Hotspot_jdk/11.0.14-1/x64
2022-03-20T00:58:58.3006458Z ##[endgroup]
2022-03-20T00:58:58.3182025Z /home/runner/work/_temp/48a9bdca-8775-4c3a-ba18-2702674db02b.sh: line 4: syntax error near unexpected token `)'
2022-03-20T00:58:58.3203797Z ##[error]Process completed with exit code 2.

@mpkorstanje
Copy link
Contributor

Superseded by:

#2502

mpkorstanje added a commit that referenced this pull request Jul 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants