-
-
Notifications
You must be signed in to change notification settings - Fork 2k
Use Github release automation #2500
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #2500 +/- ##
=========================================
Coverage 83.76% 83.76%
Complexity 2688 2688
=========================================
Files 319 319
Lines 9471 9471
Branches 917 917
=========================================
Hits 7933 7933
Misses 1201 1201
Partials 337 337 Continue to review full report at Codecov.
|
OK the Release environment is all set up - I think we should be able to run this whenever you're ready @mpkorstanje |
c40554c
to
2b28371
Compare
This is only neccesary to test this piece of infrastructure and should be reverted before the PR is merged.
83fd4a8
to
abdd854
Compare
Co-authored-by: M.P. Korstanje <[email protected]>
Doesn't work perfectly yet: https://github.com/cucumber/cucumber-jvm/actions/runs/2010145889 |
Branch protection rules were missing. |
Co-authored-by: M.P. Korstanje <[email protected]>
|
||
publish-mvn: | ||
name: Publish Maven Package | ||
needs: [pre-release-check, test-java] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have referenced test
, not test-java
.
Co-authored-by: M.P. Korstanje <[email protected]>
This looks promising: https://github.com/cucumber/cucumber-jvm/actions/runs/2010286622 |
Nope.
|
Superseded by: |
Co-authored-by: M.P. Korstanje <[email protected]>
🤔 What's changed?
release/*
branchMakefile
to no longer use docker or keybase secrets, and push to release branch instead.⚡️ What's your motivation?
Run releases transparently using GitHub actions.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
I'm curious whether we need to do anything about the
-P-examples -P-compatibility
switches which were previously being sent to themvn deploy
command. I've not reflected those in themaven-profiles
argument, but should I? What does the-
prefix mean?📋 Checklist: