Rename modules and folders to match artifact names #2596
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #2596 +/- ##
=========================================
Coverage 84.63% 84.63%
Complexity 2711 2711
=========================================
Files 321 321
Lines 9497 9497
Branches 907 907
=========================================
Hits 8038 8038
Misses 1128 1128
Partials 331 331
Continue to review full report at Codecov.
|
Polyglot release[1] assumes that projects follow a certain layout. Specifically it assumes a project is polyglot if (amongst other conditions) there is a `java/pom.xml` file. This project however is not polyglot. The `cucumber-java` module is kep in the `java` folder. And this trips up Polyglot release. By renaming all folders and modules to match the artifact names we can avoid this problem. It also simplifies the project by removing the number of unique identifiers for (more or less) the same thing. But that is just a nice coincidence. 1: https://github.com/cucumber/polyglot-release
mpkorstanje
force-pushed
the
modules-names-match-directory
branch
from
c7aea92 to
2dc0deb
Compare
mpkorstanje
changed the title
mpkorstanje
added a commit
to cucumber/docs
that referenced
this pull request
Jul 31, 2022
With cucumber/cucumber-jvm#2596 the internal structure got changed somewhat. Updated all the documentation links to match these changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Polyglot release[1] assumes that projects follow a certain layout. Specifically
it assumes a project is polyglot if (amongst other conditions) there is a
java/pom.xmlfile.This project however is not polyglot. The
cucumber-javamodule is kep in thejavafolder. And this trips up Polyglot release. By renaming all folders andmodules to match the artifact names we can avoid this problem.
It also simplifies the project by removing the number of unique identifiers for
(more or less) the same thing. But that is just a nice coincidence.
1: https://github.com/cucumber/polyglot-release