-
-
Notifications
You must be signed in to change notification settings - Fork 2k
[Core] Support diff toolwindow in IntelliJ IDEA #2608
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Core] Support diff toolwindow in IntelliJ IDEA #2608
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good on the main points. However I do feel some important details are missing and the test coverage is a bit spotty.
Please also update the CHANGELOG.md and run mvn spotless:apply
to fix the formatting.
cucumber-core/src/main/java/io/cucumber/core/plugin/TeamCityPlugin.java
Outdated
Show resolved
Hide resolved
cucumber-core/src/main/java/io/cucumber/core/plugin/TeamCityPlugin.java
Outdated
Show resolved
Hide resolved
cucumber-core/src/main/java/io/cucumber/core/plugin/TeamCityPlugin.java
Outdated
Show resolved
Hide resolved
cucumber-core/src/main/java/io/cucumber/core/plugin/TeamCityPlugin.java
Outdated
Show resolved
Hide resolved
For the toolwindow are required the "expected" and "actual" attributes in the test-failed-output message. This fixes issue: cucumber#2607
c0c3e35
to
f374d01
Compare
Codecov Report
@@ Coverage Diff @@
## main #2608 +/- ##
============================================
+ Coverage 84.72% 84.87% +0.14%
- Complexity 2696 2699 +3
============================================
Files 320 320
Lines 9512 9544 +32
Branches 908 913 +5
============================================
+ Hits 8059 8100 +41
+ Misses 1123 1111 -12
- Partials 330 333 +3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
cucumber-core/src/main/java/io/cucumber/core/plugin/TeamCityPlugin.java
Outdated
Show resolved
Hide resolved
cucumber-core/src/main/java/io/cucumber/core/plugin/TeamCityPlugin.java
Outdated
Show resolved
Hide resolved
@avokin I've pushed fixes for the suggestions I've made above. That was a bit quicker. Also added support for AssertJ, Testng and JUnit4. That should cover the most common frameworks I think. |
Thank you! Should I fix anything else? |
No, I think this is okay for now. Release will happen soonish. |
Hi @avokin2, Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾 In return for this generous offer we hope you will:
On behalf of the Cucumber core team, |
For the toolwindow are required the "expected" and "actual" attributes in the test-failed-output message.
This fixes issue: #2607
🤔 What's changed?
⚡️ What's your motivation?
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.