Fix and improve CamelCaseFunctionNameSanitizer #603
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a StringIndexOutOfBoundsException that would occur in CamelCaseFunctionNameSanitizer for function names with multiple spaces, that is for step definitions with more than one capture group.
Function names are now correctly formatted if they contain acronyms. The name sanitizer also will not change the case of words that are already pascal or camel case in the input.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug that occurs for steps with more than one capture group, for example
Given I have "this" and "that"An attempt to sanitize the function name throws a
StringIndexOutOfBoundsException.I also improved the formatting for steps/function names that have acronyms and camel/pascal case words in them.
Note: This is a copy of #592 that I sent earlier, but from the wrong branch.