Add --add-plugin option and clobber when --plugin is used #860
Conversation
When using --plugin the plugins of that type defined from a different source is clobbered. Using -Dcucumber.options="--plugin pretty" would clobber the formatter/reporter plugins defined in `@CucumberOptions`. --add-plugin does not clobber any plugins defined from a different source.
| @@ -114,11 +115,11 @@ private void parse(List<String> args) { | |||
| parsedGlue.add(gluePath); | |||
| } else if (arg.equals("--tags") || arg.equals("-t")) { | |||
| parsedFilters.add(args.remove(0)); | |||
| } else if (arg.equals("--plugin") || arg.equals("-p")) { | |||
| addPluginName(args.remove(0)); | |||
| } else if (arg.equals("--plugin") || arg.equals("--add-plugin") || arg.equals("-p")) { | |||
There was a problem hiding this comment.
I'm not sure I like renaming the semantics of -p to be --add-plugin now. This could be a suprise break for people who are currently using -p and expect that behavior to be the same.
There was a problem hiding this comment.
Oh wait, you're changing the semantics of --plugin entirely! Hm. Same thought process applies. Since it's already released, should we use --add-plugin and have those semantics be different than the existing --plugin?
There was a problem hiding this comment.
Between v1.1.4 and v1.1.5 the --glue and feature options was changed from "add" to clobber (5e3b0ea), so this kind of semantic change has been done on already released functionality before. And isn't it more surprising for people the --plugin behaves differently from all other list type options?
I know the rationale for the current behaviour of --plugin (#643 (comment)), but do think it makes thinks unnecessary hard on users that it is impossible to remove plugins defined in the @CucumberOptions annotation, without edit it in the source code. With this PR CucumberPro and others can use --add-plugin if they need the current behaviour, and the people the need the clobbering of plugins from the @CucumberOptions can do that too (and all list type options behave consistently).
|
That makes sense to me +1 for merging |
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
When using --plugin the plugins of that type defined from a different source is clobbered. Using -Dcucumber.options="--plugin pretty" would clobber the formatter/reporter plugins defined in
@CucumberOptions. --add-plugin does not clobber any plugins defined from a differentsource.
The rational for this PR is both consistency, other list type options do clobber, and it enables some use cases not possible today:
@CucumberOptions(mailing list post)