Double-check for directory exists in the ensureParentDirExists(File) #978

niberius · 2016-03-29T21:37:59Z

Hi.

I have several JUnit runners which runs cucumber tests in parallel at the same time. Each runner generate JSON file with test results to the one directory, e.g. ./target/json-files/

@CucumberOptions(
        plugin = {"json:target/json-files/Test1.json"}, ...)

Sometimes I have an issue when one of runner is unable to create reports directory because another runner already done this. And it fails with error "Failed to create directory".
I think there is a make sense to double-check if reports directory is already exists (method cucumber.runtime.io.URLOutputStream#ensureParentDirExists).

niberius · 2016-04-18T09:33:06Z

Hello.
Could you please tell me, is there any updates on this issue?
If you don't want to merge my fix, could you please advise another solution for the issue?

-------------------------------------------------------
 T E S T S
-------------------------------------------------------
Running com.localhost.tests.RunTest1
Running com.localhost.tests.RunTest2
Running com.localhost.tests.RunTest3
Running com.localhost.tests.RunTest4
Tests run: 2, Failures: 0, Errors: 2, Skipped: 0, Time elapsed: 0.413 sec <<< FAILURE! - in com.localhost.tests.RunTest2
com.localhost.tests.RunTest2  Time elapsed: 0.412 sec  <<< ERROR!
cucumber.runtime.CucumberException: java.io.IOException: Failed to create directory C:\Jenkins\workspace\MyProjectWorkspace\target\json-files
    at cucumber.runtime.formatter.PluginFactory.create(PluginFactory.java:89)
    at cucumber.runtime.RuntimeOptions.getPlugins(RuntimeOptions.java:241)
    at cucumber.runtime.RuntimeOptions$1.invoke(RuntimeOptions.java:287)
    at com.sun.proxy.$Proxy15.uri(Unknown Source)
    at cucumber.runtime.junit.JUnitReporter.uri(JUnitReporter.java:160)
    at cucumber.runtime.junit.FeatureRunner.run(FeatureRunner.java:68)
    at cucumber.api.junit.Cucumber.runChild(Cucumber.java:93)
    at cucumber.api.junit.Cucumber.runChild(Cucumber.java:37)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
    at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
    at cucumber.api.junit.Cucumber.run(Cucumber.java:98)
    at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
    at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
    at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
    at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
    at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
    at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
    at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)
Caused by: java.io.IOException: Failed to create directory C:\Jenkins\workspace\MyProjectWorkspace\target\json-files
    at cucumber.runtime.io.URLOutputStream.ensureParentDirExists(URLOutputStream.java:53)
    at cucumber.runtime.io.URLOutputStream.<init>(URLOutputStream.java:33)
    at cucumber.runtime.io.URLOutputStream.<init>(URLOutputStream.java:24)
    at cucumber.runtime.formatter.PluginFactory.convertOrNull(PluginFactory.java:142)
    at cucumber.runtime.formatter.PluginFactory.instantiate(PluginFactory.java:99)
    at cucumber.runtime.formatter.PluginFactory.create(PluginFactory.java:87)
    at cucumber.runtime.RuntimeOptions.getPlugins(RuntimeOptions.java:241)
    at cucumber.runtime.RuntimeOptions$1.invoke(RuntimeOptions.java:287)
    at com.sun.proxy.$Proxy15.uri(Unknown Source)
    at cucumber.runtime.junit.JUnitReporter.uri(JUnitReporter.java:160)
    at cucumber.runtime.junit.FeatureRunner.run(FeatureRunner.java:68)
    at cucumber.api.junit.Cucumber.runChild(Cucumber.java:93)
    at cucumber.api.junit.Cucumber.runChild(Cucumber.java:37)
    at org.junit.runners.ParentRunner$3.run(ParentRunner.java:238)
    at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:63)
    at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:236)
    at org.junit.runners.ParentRunner.access$000(ParentRunner.java:53)
    at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:229)
    at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:26)
    at org.junit.runners.ParentRunner.run(ParentRunner.java:309)
    at cucumber.api.junit.Cucumber.run(Cucumber.java:98)
    at org.apache.maven.surefire.junit4.JUnit4Provider.execute(JUnit4Provider.java:283)
    at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:173)
    at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:153)
    at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:128)
    at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:203)
    at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:155)
    at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:103)

alphaCentavra · 2016-05-05T09:17:12Z

This issue affects me too... Please apply some fix for it.

dkowis · 2016-05-11T20:45:57Z

Could you provide some kind of test? Some sort of proof that this solves the problem? Parallel execution isn't officially supported yet. If you can provide tests we can add to prove that it works, we can probably get it merged.

…sts(File)

niberius · 2016-05-12T15:56:43Z

I did it. Could you please review my test? If you run it without my changes in URLOutputStream, you'll get many "Failed to create parent directory" errors. But another assertion in my test which verifies that all necessary temp files and their parents are created will be passed.
I spent an hours to emulate my situation in test. Please, note that this is an intermittent issue and in my real project it reproduces ~2 times for 10 runs (in average). For temporarily fix, I've put URLOutputStream with my changes to my project with the same package name and cucumber getting my modified class from class path. Issue is not appears in that case but in my point of view, this is an unreliable solution and "bicycle". Some fixes should be made inside cucumber. Maybe my, maybe you own, as you wish...
Thank you in advance.

aslakhellesoy · 2016-05-12T16:13:03Z

core/src/test/java/cucumber/runtime/io/URLOutputStreamTest.java

-import org.webbitserver.HttpResponse;
-import org.webbitserver.WebServer;
+import org.junit.rules.TemporaryFolder;
+import org.webbitserver.*;


No star imports please, and please undo reordering of imports. Try to reduce the PR to significant changes only.

Ooops, it wasn't me, it was Intellij Idea. Sorry. Fixed in commits 6ad8186, cf811be

…order inside other imports

RichardBradley · 2016-07-30T19:26:18Z

+1 -- I have had the same issue, and can confirm this fixes it.

Also update History.md.

lock · 2018-10-25T02:13:50Z

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

Double-check for directory exists in the ensureParentDirExists(File)

f0efe8d

niberius added 2 commits May 12, 2016 18:17

Tests for double-check for directory exists in the ensureParentDirExi…

320cc59

…sts(File)

URLOutputStreamTest - java 1.6 fixes

cfc8e03

aslakhellesoy reviewed May 12, 2016
View reviewed changes

niberius added 2 commits May 12, 2016 19:27

URLOutputStreamTest - imports order fixed; asterisk imports removed

6ad8186

URLOutputStreamTest - LinkedBlockingDeque import was put in alphabet …

cf811be

…order inside other imports

brasmusson mentioned this pull request Jul 30, 2016

Fix directory creation race condition #1032

Closed

brasmusson merged commit cf811be into cucumber:master Jul 31, 2016

brasmusson added a commit that referenced this pull request Jul 31, 2016

Merge #978 'Double-check for directory exists in ...'.

e6ea17b

Also update History.md.

lock bot locked as resolved and limited conversation to collaborators Oct 25, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Double-check for directory exists in the ensureParentDirExists(File) #978

Double-check for directory exists in the ensureParentDirExists(File) #978

niberius commented Mar 29, 2016

niberius commented Apr 18, 2016 •

edited

Loading

alphaCentavra commented May 5, 2016

dkowis commented May 11, 2016

niberius commented May 12, 2016 •

edited

Loading

aslakhellesoy May 12, 2016

niberius May 12, 2016

RichardBradley commented Jul 30, 2016

lock bot commented Oct 25, 2018

Double-check for directory exists in the ensureParentDirExists(File) #978

Double-check for directory exists in the ensureParentDirExists(File) #978

Conversation

niberius commented Mar 29, 2016

niberius commented Apr 18, 2016 • edited Loading

alphaCentavra commented May 5, 2016

dkowis commented May 11, 2016

niberius commented May 12, 2016 • edited Loading

aslakhellesoy May 12, 2016

Choose a reason for hiding this comment

niberius May 12, 2016

Choose a reason for hiding this comment

RichardBradley commented Jul 30, 2016

lock bot commented Oct 25, 2018

niberius commented Apr 18, 2016 •

edited

Loading

niberius commented May 12, 2016 •

edited

Loading