Skip to content
This repository was archived by the owner on Dec 21, 2024. It is now read-only.

Add "Myth" to each myth title #657

Merged
merged 1 commit into from
Aug 29, 2021
Merged

Conversation

GaTechThomas
Copy link
Contributor

@GaTechThomas GaTechThomas commented Aug 29, 2021

There's so much unfocused effort that pulls incorrect conclusions from info such as this document, that it seems that these myths are being treated as the opposite.

Take a look at this page with the mindset that you're new and just did a web search, and didn't read the entire page. With this mindset as a given, it is easy to see how these items can be taken with incorrect, opposite understanding.

Adding "Myth" to the the title of each myth reduces the chance that these items will be taken in a way that is opposite the intent.

Description

Describe your changes in detail

Motivation & context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here.

e.g. "Fixes #99"

Type of change

  • Refactoring/debt (improvement to code design or tooling without changing behaviour)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new behaviour)
  • Breaking change (will cause existing functionality to not
    work as expected)

Remember to add an entry to the relevant section of CHANGELOG.md as part of this pull request.

Note to other contributors

If your change may impact future contributors, explain it here, and remember to update README.md and CONTRIBUTING.md accordingly.

Update required of cucumber.io/docs

If the Cucumber documentation will require an update,
submit an issue or ideally a pull request to cucumber/docs and
reference it here.

e.g. "Ref: cucumber/docs/pull/#99"

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

There's so much unfocused effort that pulls incorrect conclusions from info such as this document, that it seems that these myths are being treated as the opposite. 

Take a look at this page with the mindset that you're new and just did a web search, and didn't read the entire page. With this mindset as a given, it is easy to see how these items can be taken with incorrect, opposite understanding.

Adding "Myth" to the the title of each myth reduces the chance that these items will be taken in a way that is opposite the intent.
@GaTechThomas
Copy link
Contributor Author

FYI, the "contributing" document referenced in the above checklist does not exist.

Copy link
Contributor

@olleolleolle olleolleolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I very much like this clarifying detail

@olleolleolle olleolleolle merged commit f403f7c into cucumber:main Aug 29, 2021
@aslakhellesoy
Copy link
Contributor

Hi @GaTechThomas,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants