Skip to content
This repository was archived by the owner on Dec 21, 2024. It is now read-only.

Updated absolute URL to cucumber docs #720

Merged
merged 1 commit into from
Feb 4, 2022
Merged

Updated absolute URL to cucumber docs #720

merged 1 commit into from
Feb 4, 2022

Conversation

declark
Copy link
Contributor

@declark declark commented Feb 2, 2022

Description

Describe your changes in detail

Motivation & context

Why is this change required? What problem does it solve?
If it fixes an open issue, please link to the issue here, e.g. "Fixes #99"

Type of change

  • Refactoring/debt (improvement to code design or tooling without changing behaviour)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new behaviour)
  • Breaking change (will cause existing functionality to not
    work as expected)

Checklist:

  • I have read the CONTRIBUTING document.
  • My change needed additional tests
    • I have added tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

@aurelien-reeves
Copy link
Contributor

Great! It works fine, thanks @declark 🙏

(It is so simple ... why didn't we found that ourselves!?)

@aurelien-reeves
Copy link
Contributor

A lot of absolute URL are still part of the content. Is there any reason for that @declark?

@declark
Copy link
Contributor Author

declark commented Feb 4, 2022

A lot of absolute URL are still part of the content. Is there any reason for that @declark?

Yes, those pages live on the cucumber.io website as part of a different CMS. We proxy in the docs. The only adjustment needed was to update the single hardcoded url to the docs so that it doesn't direct users away from the preview build.

@declark declark merged commit 916e816 into main Feb 4, 2022
@declark declark deleted the hardcoded-docs-link branch February 4, 2022 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants