Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove duplications in steps due to empty parameters #373

Merged
merged 3 commits into from
Mar 29, 2025

Conversation

mcarleio
Copy link
Contributor

🤔 What's changed?

This fixes an issue, where part of the steps are duplicated while rendering due to empty parameters.

feature:
image

stepdefinition:
image

output:
image

⚡️ What's your motivation?

Fixes the annoying bug, that part of the steps are duplicated multiple times in the output.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

nothing

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link

netlify bot commented Mar 28, 2025

Deploy Preview for cucumber-react-preview ready!

Name Link
🔨 Latest commit 06e8145
🔍 Latest deploy log https://app.netlify.com/sites/cucumber-react-preview/deploys/67e7bc74dc53e40008aa1040
😎 Deploy Preview https://deploy-preview-373--cucumber-react-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mpkorstanje
Copy link
Contributor

Can you remove the whitespace changes from the PR?

@mcarleio
Copy link
Contributor Author

Can you remove the whitespace changes from the PR?

Oh, sorry, fixed it

Copy link
Contributor

@davidjgoss davidjgoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks very much @mcarleio!

@davidjgoss davidjgoss merged commit c279915 into cucumber:main Mar 29, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants