Unify 587 - adding cy.mount api doc #4234
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cowboy
suggested changes
Nov 29, 2021
elylucas
changed the title
elylucas
changed the title
cowboy
reviewed
Dec 2, 2021
elylucas
force-pushed
the
unify-397-custom-cy-mount-command
branch
from
066231a to
44d76a3
Compare
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/cypress-io/cypress-documentation/49BQNpWfWYMFPV5MLVYbxkS8DQWx |
elylucas
changed the title
amirrustam
approved these changes
Dec 7, 2021
There was a problem hiding this comment.
Looks great 👍, and I'm assuming the React and Vue examples were directly tested.
One thing I did feel that was missing was just "what are all the mount API options" since this is the "mount API docs," but I know this is something additional we've got an issue in Jira to add later.
cowboy
suggested changes
Dec 8, 2021
Co-authored-by: Ben Alman <[email protected]>
Co-authored-by: Ben Alman <[email protected]>
Co-authored-by: Ben Alman <[email protected]>
Co-authored-by: Ben Alman <[email protected]>
cowboy
suggested changes
Dec 10, 2021
cowboy
approved these changes
Dec 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira:
https://cypress-io.atlassian.net/browse/UNIFY-587
Preview:
https://deploy-preview-4234--cypress-docs.netlify.app/api/commands/mount