This repository was archived by the owner on Oct 1, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 22
fix: Reduce the verbosity of error messages #102
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
kuceb
suggested changes
Aug 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
awesome. I believe this occurs not only for Module not found
errors, for example this syntax error (from webpack default PR snapshots)
Error: Webpack Compilation Error
describe('fail', - > ); ./cypress/integration/typescript_failing_spec.tsXX:XX
^ Module parse failed: Unexpected token (4:19)
ParseError: Unexpected token File was processed with these loaders:
* ../../../../node_modules/@cypress/webpack-batteries-included-preprocessor/node_modules/ts-loader/index.js
You may need an additional loader to handle the result of these loaders.
| // The code below is ignored by eslint
| // because it tests failing spec.
> describe('fail', - > );
|
@ multi ./cypress/integration/typescript_failing_spec.ts main[0]
/foo/bar/.projects/e2e/cypress/integration/typescript_failing_spec.ts
./cypress/integration/typescript_failing_spec.ts
[tsl] ERROR in /foo/bar/.projects/e2e/cypress/integration/typescript_failing_spec.ts(3,19)
TS1109: Expression expected.
@ multi ./cypress/integration/typescript_failing_spec.ts main[0]
/foo/bar/.projects/e2e/cypress/integration/typescript_failing_spec.ts
./cypress/integration/typescript_failing_spec.ts
[tsl] ERROR in /foo/bar/.projects/e2e/cypress/integration/typescript_failing_spec.ts(3,21)
TS1109: Expression expected.
@ multi ./cypress/integration/typescript_failing_spec.ts main[0]
@bkucera I now have it removing everything after '@ multi' in error messages, as that seems to all be extra nonsense. |
kuceb
approved these changes
Aug 10, 2020
🎉 This PR is included in version 5.4.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
panzarino
pushed a commit
to cypress-io/cypress
that referenced
this pull request
Sep 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Webpack's errors can be overly verbose. This reduces them to only useful information.
Module Not Found Before:
Module Not Found After:
Syntax Error Before:*
Syntax Error After:*