This repository was archived by the owner on Oct 1, 2020. It is now read-only.
fix: fix compilation error message #63
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuceb
commented
Feb 21, 2020
| err.stack = jsonStats.errors.join('\n\n') | ||
| err.message += `\n${jsonStats.errors | ||
| // remove stack trace lines since they're useless for debugging | ||
| .map((err) => err.replace(/\n\s*at.*/g, '').replace(/From previous event:\n?/g, '')) |
There was a problem hiding this comment.
this same logic is used in test runner to strip stack trace lines, so we're just moving this logic up
https://github.com/cypress-io/cypress/blob/master/packages/server/lib/plugins/preprocessor.coffee#L16
There was a problem hiding this comment.
ughh, this is so so weird - why have 3 lines of code inside a string template?
There was a problem hiding this comment.
eslint auto-fixed to that when i tried to add '\n'
bahmutov
previously approved these changes
Feb 21, 2020
|
I have noticed this says "fix:" but does not reference an issue and does not have a test |
|
snapshot is updated, but I'll add an assertion and open an issue |
bahmutov
approved these changes
Feb 21, 2020
panzarino
pushed a commit
to cypress-io/cypress
that referenced
this pull request
Sep 17, 2020
…cessor#63) * append error to error.message instead of stack
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
append error to error.message instead of error.stack
Error: Webpack Compilation Errornot showing up in the errore.originalStackunnecessaryfix #64