This repository was archived by the owner on Oct 1, 2020. It is now read-only.
fix: fix file watching on compilation error #66
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuceb
commented
Feb 27, 2020
| @@ -157,7 +162,7 @@ const preprocessor = (options = {}) => { | |||
| latestBundle = createDeferred() | |||
| bundles[filePath] = latestBundle.promise | |||
|
|
|||
| bundles[filePath].tap(() => { | |||
| bundles[filePath].finally(() => { | |||
There was a problem hiding this comment.
this should be the only functional change
chrisbreiding
approved these changes
Feb 28, 2020
kuceb
changed the title
panzarino
pushed a commit
to cypress-io/cypress
that referenced
this pull request
Sep 17, 2020
…ck-preprocessor#66) fix issue where compilation error does not cause cypress to refetch the spec and display the error without a manual page reload.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix issue where compilation error does not cause cypress to refetch the spec and display the error without a manual page reload.
fix #65
finally()instead oftap()sofile.emit('rerun')will be called for both the failing/success code pathsalso
webpack@latestto potentially catch new issues (maybe this should be a separate automation, and we should test fixed previous versions for compatability)how to reproduce error (before this change):
in this repo: