breaking: remove Angular 17 support #31446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AtofStryker
force-pushed
the
breaking/remove_angular_17_cursor
branch
5 times, most recently
from
e1def53 to
dce2f6e
Compare
BREAKING CHANGE: Removed support for Angular 17. Only Angular 18 and 19 are now supported. This change affects the @cypress/angular package. Addresses #31303.
AtofStryker
force-pushed
the
breaking/remove_angular_17_cursor
branch
3 times, most recently
from
cca72cd to
aa36f04
Compare
AtofStryker
force-pushed
the
breaking/remove_angular_17_cursor
branch
from
aa36f04 to
93b6ba4
Compare
jennifer-shehane
added
the
type: breaking change
jennifer-shehane
requested changes
Apr 4, 2025
|
@jennifer-shehane this really should be a WIP but I was trying to figure out how to kick off CI with cursor. As it stands the cursor agent wrote this whole PR 😬 |
There was a problem hiding this comment.
Copilot reviewed 16 out of 21 changed files in this pull request and generated no comments.
Files not reviewed (5)
- npm/angular/package.json: Language not supported
- npm/cypress-schematic/package.json: Language not supported
- system-tests/projects/angular-17/angular.json: Language not supported
- system-tests/projects/angular-17/package.json: Language not supported
- system-tests/projects/angular-signals/package.json: Language not supported
Comments suppressed due to low confidence (1)
system-tests/projects/angular-signals/src/signals-complex/signals-complex.component.ts:29
- The updated comment is now ambiguous regarding the affected Angular version. Since Angular 17 is no longer supported, consider clarifying the comment to indicate whether this bug pertains to older Angular versions or removing the version-specific note altogether.
// there is a bug in Angular that doesn't rerender the signal when set outside the component context
cypress
|
||||||||||||||||||||||||||||||||||||||||
| Project |
cypress
|
| Branch Review |
breaking/remove_angular_17_cursor
|
| Run status |
|
| Run duration | 15m 39s |
| Commit |
|
| Committer | AtofStryker |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
29
|
Skipped
|
0
|
Passing
|
794
|
| View all changes introduced in this branch ↗︎ | |
UI Coverage
63.22%
|
|
|---|---|
|
Untested elements
|
30
|
|
Tested elements
|
55
|
Accessibility
96.19%
|
|
|---|---|
|
Failed rules
|
0 critical
4 serious
1 moderate
0 minor
|
|
Failed elements
|
196
|
…ckages live historically
…reaking/remove_angular_17_cursor
|
@AtofStryker There's some tests failing here. |
AtofStryker
added
npm: @cypress/angular
…s-io/cypress into breaking/remove_angular_17_cursor
jennifer-shehane
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR removes support for Angular 17 as part of our ongoing maintenance and support strategy. This is a breaking change that affects users of the
@cypress/angularpackage.Changes
Breaking Changes
@cypress/angularpackage no longer supports Angular 17Migration Steps
Users currently using Angular 17 with Cypress should:
Related Issues
Testing
Additional Notes
Tests have been removed related to Angular 17. Documentation updates for Cypress 15 can be found in this PR