Skip to content

breaking: remove typescript 4 from component testing #31492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

AtofStryker
Copy link
Contributor

Additional details

removes typescript 4 support from CT scaffolding. For e2e testing, tsx should work with TypeScript 4 but we will not be supporting it generally moving forward

Steps to test

How has the user experience changed?

PR Tasks

@AtofStryker AtofStryker self-assigned this Apr 11, 2025
Copy link

cypress bot commented Apr 11, 2025

cypress    Run #61580

Run Properties:  status check passed Passed #61580  •  git commit ec0e38d5fc: breaking: remove support for typescript 4
Project cypress
Branch Review breaking/remove_typescript_4
Run status status check passed Passed #61580
Run duration 11m 44s
Commit git commit ec0e38d5fc: breaking: remove support for typescript 4
Committer AtofStryker
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 694
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 802
View all changes introduced in this branch ↗︎
UI Coverage  33.47%
  Untested elements 125  
  Tested elements 76  
Accessibility  92.18%
  Failed rules  3 critical   7 serious   1 moderate   1 minor
  Failed elements 525  

@AtofStryker AtofStryker force-pushed the breaking/remove_typescript_4 branch from 58cc568 to ec0e38d Compare April 14, 2025 17:53
@jennifer-shehane jennifer-shehane self-requested a review April 18, 2025 17:33
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Confirmed that it basically still works with TS 4 if you skip the install step, it's just not in the setup screen as supported.

Screenshot 2025-04-18 at 1 53 12 PM

@AtofStryker
Copy link
Contributor Author

Looks good. Confirmed that it basically still works with TS 4 if you skip the install step, it's just not in the setup screen as supported.

Screenshot 2025-04-18 at 1 53 12 PM

@jennifer-shehane correct. As far as E2E is concerned, we don't check the TypeScript version but tsx should be able to run it since we are really just using whatever version of TypeScript the user has installed. That being said we likely don't want official support for the older versions but I don't think we have that defined anywhere?

@AtofStryker AtofStryker merged commit 0e1c8c1 into release/15.0.0 Apr 18, 2025
83 of 86 checks passed
@AtofStryker AtofStryker deleted the breaking/remove_typescript_4 branch April 18, 2025 19:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants