REF: Spin off tree -> code compilation into a separate module #136
Conversation
| @@ -70,16 +69,6 @@ def generate_code( | |||
| ) -> None: | |||
| plugin_options = request.parameter.split(",") if request.parameter else [] | |||
There was a problem hiding this comment.
Does anyone know how to encode an alternative template/compiler (i.e. to swap out betterproto.plugin.compiler.py) as part of the command line options?
There was a problem hiding this comment.
The goal here is that at the very least someone could copy compiler.py to my_compiler.py and edit the template (or the rendering method altogether) and pass an option to protoc that would tell plugin.py to import my_compiler.outputfile_compiler and use that instead of the default one. It's not a super clean API or anything but it should be powerful and a good starting place for other changes. This options parsing doesn't need to be part of this PR, just asking for future reference.
There was a problem hiding this comment.
I guess you have in mind being able to do something like:
protoc --python_betterproto_out=lib --custom_opt=TYPE_VALIDATION,SILLY_WALKS,WHATEVER -I ...I like the idea of stuff being modular and potentially configurable in this way. But I wouldn't race to provide an API to support fully support this without a real use case.
There was a problem hiding this comment.
I think this change stands on it's own, and I agree with you that more discussion is needed before providing an API to do the above, but I do want to make sure that this change is at least compatible with that approach.
This small edit splits off the actual code generation based on the
models.pyclasses into its own module. The hope is that it would be possible to swap out the newcompiler.pyfor another module that implements theoutputfile_compilerfunction with the same signature, thus allowing for generation of arbitrary code based on themodels.pytree structure.