Skip to content

Fix readme docs 'Async gRPC Support' #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Conversation

bekhzod91
Copy link
Contributor

Unusable docs in section "Async gRPC Support server-facing"

Traceback (most recent call last):
  File "/Users/bekhzod/Projects/betterproto-test/.venv/lib/python3.9/site-packages/grpclib/server.py", line 440, in request_handler
    await method_func(stream)
  File "/Users/bekhzod/Projects/betterproto-test/echo/__init__.py", line 72, in __rpc_echo
    await stream.send_message(response)
  File "/Users/bekhzod/Projects/betterproto-test/.venv/lib/python3.9/site-packages/grpclib/server.py", line 195, in send_message
    await send_message(self._stream, self._codec, message, self._send_type)
  File "/Users/bekhzod/Projects/betterproto-test/.venv/lib/python3.9/site-packages/grpclib/stream.py", line 44, in send_message
    reply_bin = codec.encode(message, message_type)
  File "/Users/bekhzod/Projects/betterproto-test/.venv/lib/python3.9/site-packages/grpclib/encoding/proto.py", line 45, in encode
    raise TypeError('Message must be of type {!r}, not {!r}'
TypeError: Message must be of type <class 'echo.EchoResponse'>, not <class 'str'>

@bekhzod91 bekhzod91 changed the title Fix readme docs 'Async gRPC Support' Fix readme docs 'Async gRPC Support' pull request Jun 18, 2021
@bekhzod91 bekhzod91 changed the title Fix readme docs 'Async gRPC Support' pull request Fix readme docs 'Async gRPC Support' Jun 21, 2021
Copy link
Collaborator

@nat-n nat-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking the time to fix this!

@nat-n nat-n merged commit a331265 into danielgtaylor:master Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants