Format field comments also as docstrings #304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for the pointers @Gobot1234 !
I didn't manage to run the tests (
poe
command not found) and I'm not sure if/how I should generate the code of the project files.I gotta jump now (christmas dinner..), but please feel free to give additional instructions or take over the branch!
Enjoy the holiday!
PS.: I tested it on my code by generating & installing the Wheel. Looks like in comparison with the current release it puts all classes in
__init__.py
now? Also FYI: The linefrom betterproto.grpc.grpclib_server import ServiceBase
was unnecessarily included in the generated file.Closes #303