Split up betterproto into separate modules #322
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes implementing some critical parts of the API to be implemented in a c extension somewhere down the road.
I'm happy to fix up any currently open pull requests to get this merged.
I haven't entirely followed #49 (comment) as I think it's good to keep everything as together as possible (this also slightly relies on some of my other PRs being merged).
I'd like to draw particular attention to https://github.com/Gobot1234/python-betterproto/blob/086da0b6651712226b8382ca0c8477e6519230a9/src/betterproto/lib/google/protobuf/__init__.py as currently it requires editing to actually allow it to be importable without using local imports (which I'd really like to avoid). I'd be interested to hear if anyone can think of a way to avoid this.
TODO
Closes #49