Skip to content

Split up betterproto into separate modules #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Gobot1234
Copy link
Collaborator

This makes implementing some critical parts of the API to be implemented in a c extension somewhere down the road.

I'm happy to fix up any currently open pull requests to get this merged.

I haven't entirely followed #49 (comment) as I think it's good to keep everything as together as possible (this also slightly relies on some of my other PRs being merged).

I'd like to draw particular attention to https://github.com/Gobot1234/python-betterproto/blob/086da0b6651712226b8382ca0c8477e6519230a9/src/betterproto/lib/google/protobuf/__init__.py as currently it requires editing to actually allow it to be importable without using local imports (which I'd really like to avoid). I'd be interested to hear if anyone can think of a way to avoid this.

TODO

  • Run isort
  • Fix any created merge conflicts

Closes #49

@Gobot1234 Gobot1234 closed this Dec 3, 2022
@Gobot1234
Copy link
Collaborator Author

I'll remake this one day when it stands more of a chance of being merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Split code up into multiple modules
1 participant