Skip to content

[fix] to_dict modifies the underlying message (#151) #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
May 9, 2022
Merged

[fix] to_dict modifies the underlying message (#151) #378

merged 6 commits into from
May 9, 2022

Conversation

GrownNed
Copy link
Contributor

@GrownNed GrownNed commented Apr 23, 2022 •
edited by Gobot1234
Loading

Fixes #151

@Gobot1234
Copy link
Collaborator

Would you mind adding a test for this?

@Gobot1234
Copy link
Collaborator

I'm not entirely sure what the issue on the tests is but I'd guess the line before the assignment to output should check if output_map (I haven't tested this)

abn
abn reviewed Apr 23, 2022
View reviewed changes
@GrownNed GrownNed requested a review from abn April 25, 2022 21:00
@Gobot1234 Gobot1234 merged commit 85e4be9 into danielgtaylor:master May 9, 2022
@Gobot1234
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gobot1234 Gobot1234 Gobot1234 approved these changes

@abn abn Awaiting requested review from abn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to_dict modifies the underlying message
3 participants
@GrownNed @Gobot1234 @abn