Pull down the include_default_values argument to to_json
#405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `to_json` method does not include the `include_default_values` option from `to_dict`. While the implementation to `to_json` is almost litteraly only a call to `to_dict()` (and thus trivial to replace), it is more convenient for users to not have to reimplement it when the option is desired.
|
Might also be a good idea to add support for the casing arg, not too fussed about it though. Thanks for the PR. |
|
Added. BTW the latest version on pypi is quite old (and buggy). It would be worthwhile updating. |
|
Would you mind also adding a couple of tests for this (1 or 2 should be enough). The newest version on pypi was released yesterday (I hope it's not too buggy) you can install it now but you need to use the |
I was using 1.2.5 I believe, which was not working properly w.r.t the |
|
I'll add tests when I get a moment today |
|
@Gobot1234 You got the tests :) |
|
Thanks! |
Gobot1234
approved these changes
Aug 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
to_jsonmethod does not include theinclude_default_valuesoption from
to_dict. While the implementation toto_jsonisalmost litteraly only a call to
to_dict()(and thus trivial toreplace), it is more convenient for users to not have to reimplement it
when the option is desired.