-
Notifications
You must be signed in to change notification settings - Fork 229
fix: support pydantic-version google pb #568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This is a breaking change for no real reason. Please can you keep the default lib.google.protobuf as the standard dataclasses version |
That's the reason why I keep
While pydantic one is just an extra add-on for any Also tests are passed |
@Gobot1234 what's broken? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please can you delete the @generated
from the top of these files and remind people to include changes from the history (e.g. ii64@5666393 which I can see you've included)
Removed |
Thanks! One last thing, can you add a test for this situation so it doesn't happen again. |
Could you try to check and run the CI again? CI is green on my end @Gobot1234 |
Thank you! |
Summary
When using pydantic_dataclass option, the code-genererated stub still using non-pydantic version of dataclass, since we are not updating the refs, we blow up stack due to recursion, e.g. the use of
google.protobuf.Struct
.Checklist