Skip to content

refactor: separate module from runtime #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2021

Conversation

danielroe
Copy link
Owner

BREAKING CHANGE: all imports are now from typed-vuex rather than nuxt-typed-vuex, which is exclusively the module in your nuxt.config

BREAKING CHANGE: all imports are now from `typed-vuex` rather than `nuxt-typed-vuex`, which is *exclusively* the module in your `nuxt.config`
@vercel
Copy link

vercel bot commented Mar 27, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/danielroe/nuxt-typed-vuex/FSNSbsb8qp6tC8UFBF4T56ziUFHG
✅ Preview: https://nuxt-typed-vue-git-refactor-separate-module-from-runtime-77fce0.vercel.app

@danielroe danielroe self-assigned this Mar 27, 2021
@codecov
Copy link

codecov bot commented Mar 27, 2021

Codecov Report

Merging #219 (04eec84) into main (5ad99db) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #219   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines           85        81    -4     
  Branches        15        10    -5     
=========================================
- Hits            85        81    -4     
Impacted Files Coverage Δ
packages/typed-vuex/test/fixture/index.ts 100.00% <ø> (ø)
packages/typed-vuex/test/fixture/submodule.ts 100.00% <ø> (ø)
packages/nuxt-typed-vuex/src/index.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ad99db...04eec84. Read the comment docs.

@danielroe danielroe merged commit b8d556b into main Mar 27, 2021
@danielroe danielroe deleted the refactor/separate-module-from-runtime branch March 27, 2021 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant