Skip to content

fix: state lazy evaluation in accessor #75

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2020
Merged

fix: state lazy evaluation in accessor #75

merged 1 commit into from
Feb 3, 2020

Conversation

moajo
Copy link
Contributor

@moajo moajo commented Feb 3, 2020

This pull request fix #71

Since the state was being evaluated when createAccessor was called, subsequent changes seemed to be ignored.

https://codesandbox.io/s/17967
will work with this fix.

@danielroe
Copy link
Owner

@moajo Thanks - looks good to me 😃

@danielroe danielroe merged commit bae68f5 into danielroe:master Feb 3, 2020
@danielroe
Copy link
Owner

Now published 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@moajo moajo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix: computed property re-evaluation doesn't work when used replaceState()
2 participants
@moajo @danielroe