Skip to content

Enhancement: reduce errors generated from JSDoc expectations #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2019

Conversation

igneel64
Copy link
Contributor

@igneel64 igneel64 commented Aug 5, 2019

Current state:
Currently some minor typos etc are generating couple of warnings/errors when checking compliance with JSDoc.

Changes introduced:
Fix documentation for function definitions that would generate these errors.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 41cc0b4 on igneel64:jsdoc-method-definition-fixes into 19c810b on danivek:master.

@coveralls
Copy link

coveralls commented Aug 5, 2019

Coverage Status

Coverage remained the same at 100.0% when pulling 69916a7 on igneel64:jsdoc-method-definition-fixes into 19c810b on danivek:master.

@danivek
Copy link
Owner

danivek commented Aug 5, 2019

Thanks @igneel64 !

Maybe we can add eslint-plugin-jsdoc to enforce jsdoc consistency.

What do you think about it ?

@igneel64
Copy link
Contributor Author

igneel64 commented Aug 5, 2019

@danivek Happy to contribute!
Really great that you came up with this plugin, didn't even know it myself!
Checked it up and I think the recommended rules will be just fine and will promote consistency for the project.

I will add the plugin, make the required changes and come back to you.

@igneel64
Copy link
Contributor Author

igneel64 commented Aug 6, 2019

@danivek Ready for your review.

@danivek
Copy link
Owner

danivek commented Aug 6, 2019

Wow, I would not have been so far on adding jsdoc when it was missing. 👍

Big thanks ! @igneel64

@danivek danivek merged commit 728d1bf into danivek:master Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants