Skip to content

"webpack-dev-server": "^3.1.14" #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

"webpack-dev-server": "^3.1.14" #10

wants to merge 2 commits into from

Conversation

orenyodfat
Copy link
Contributor

@orenyodfat orenyodfat commented Jan 6, 2019 •
edited
Loading

fix #6

@orenyodfat orenyodfat requested a review from dkent600 January 6, 2019 11:43
@dkent600
Copy link
Contributor

dkent600 commented Jan 6, 2019

@orenyodfat Have you confirmed that this eliminates all the high security risks?

@orenyodfat
Copy link
Contributor Author

@orenyodfat Have you confirmed that this eliminates all the high security risks?

Not sure though it want heart.
webpack/webpack-dev-server#1615

@dkent600
Copy link
Contributor

dkent600 commented Jan 7, 2019

Not sure though it want heart.

Can you please rephrase? I don't understand.

@orenyodfat
Copy link
Contributor Author

orenyodfat commented Jan 7, 2019 •
edited
Loading

Not sure though it want heart.

Can you please rephrase? I don't understand.

it solve 3 out of 17 security audit warnings..
use npm audit for the report

@orenyodfat
Copy link
Contributor Author

orenyodfat commented Jan 8, 2019 •
edited
Loading

This is the status currently
found 17 vulnerabilities (10 low, 1 moderate, 6 high)
it need to be addressed

@dkent600
Copy link
Contributor

dkent600 commented Jan 9, 2019

I have already solved this problem 100% in a separate branch. This PR only does a partial job.

@dkent600 dkent600 closed this Jan 9, 2019
@dkent600 dkent600 deleted the webpack branch May 28, 2019 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leviadam leviadam leviadam approved these changes

@dkent600 dkent600 Awaiting requested review from dkent600

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"We found a potential security vulnerability in one of your dependencies."
3 participants
@orenyodfat @dkent600 @leviadam