Steps to regenerate Protobuf classes #13
Assignees
Labels
triaged/resolved
Items triaged and ready
Comments
|
I am new to this code base as well. I see you have a PR and it re-generated some protobuf code. Can you share some insights? |
|
I have changed the code to not version control the auto-generated files and copies the proto files instead. A simple compile task will generate the protobuf files. The documentation should be updated to reflect that and mention that to update the proto files, there should be a copy from dapr/dapr into this repo (maybe also create a maven task to download this automatically). |
artursouza
added
good first issue
|
Using git submodules is not ideal as it requires constant update of the commit hash where the submodule refers to. A task to download may be the best solution, unless the protobuf generator can consume remote URLs |
|
I had discussed this with some folks. The Java proto files might be behind the master proto intentionally. The scenario is the one we have now where there is a breaking change in master branch but it is still not stable yet. We might need to download from a release branch to kind of guarantee an immutable proto file. Then, once the proto file in master branch is stable, we might want to use that instead of a release brach version. For this reason, we are copying the file manually. I am in favor of having a task to download from master but don't have that as a convenience and not automatically included in the maven lifecycle. |
|
It should be possible to automatically download the file from a URL. Then we just need to point to a file within a given commit ref in the URL and we have an immutable file to download from and have consistent behavior of the build pipeline. @JuanJose-Herrera is looking into this now. |
|
We will merge the PR to automatically download the proto from dapr/dapr repo - we are just waiting for milestone 0.4 to be released this week. |
skyao
referenced
this issue
in skyao/java-sdk
Sep 6, 2023
Signed-off-by: Mahmut Canga <[email protected]>
mukundansundar
added a commit
that referenced
this issue
Sep 13, 2023
* Add ElementType.Type to ActorType (#812) Signed-off-by: LionTao <[email protected]> Signed-off-by: LionTao <[email protected]> Co-authored-by: Mukundan Sundararajan <[email protected]> Co-authored-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Bump codecov/codecov-action from 3.1.0 to 3.1.1 (#788) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.0 to 3.1.1. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/master/CHANGELOG.md) - [Commits](codecov/codecov-action@v3.1.0...v3.1.1) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Update springboot to latest minor.patch version. (#826) Signed-off-by: Mahmut Canga <[email protected]> * Use runtime 1.10.0-rc.X and CLI 1.10.0-rc.X (#827) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Upgrade the version to 1.9.0-SNAPSHOT (#829) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Generate updated javadocs for 1.8.0 (#836) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Update Dapr runtime and CLI to 1.10. (#837) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Inject autoconfiguration in the Spring Boot 3 style (#831) * Bump from spring boot 2.3.5.RELEASE to 2.7.8 Signed-off-by: Sergio <[email protected]> (cherry picked from commit 9152c91) * Ensure old versions of spring boot are still compatible Signed-off-by: Sergio <[email protected]> --------- Signed-off-by: champel <[email protected]> Signed-off-by: Sergio <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Bump from reactor 2.3.5.RELEASE to 2.7.8 (#830) * Bump from reactor 2.3.5.RELEASE to 2.7.8 Signed-off-by: Sergio <[email protected]> * Simplification Signed-off-by: Sergio <[email protected]> --------- Signed-off-by: Sergio <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Test multiple reminder state types + improve timer tests. (#855) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Convert Config API to Stable endpoints. (#846) Signed-off-by: Mahmut Canga <[email protected]> * Add PubSub subscriber examples over gPRC (#833) * add grpc subscriber Signed-off-by: MregXN <[email protected]> * modify README.md Signed-off-by: MregXN <[email protected]> * modify README.md in examples Signed-off-by: MregXN <[email protected]> * Modify DaprApplication to support examples where protocol is not specified. Signed-off-by: MregXN <[email protected]> * modify formatter to pass checkstyle Signed-off-by: MregXN <[email protected]> * Update springboot to latest minor.patch version. (#826) Signed-off-by: MregXN <[email protected]> * Use runtime 1.10.0-rc.X and CLI 1.10.0-rc.X (#827) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: MregXN <[email protected]> * Upgrade the version to 1.9.0-SNAPSHOT (#829) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: MregXN <[email protected]> * Generate updated javadocs for 1.8.0 (#836) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: MregXN <[email protected]> * Update Dapr runtime and CLI to 1.10. (#837) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: MregXN <[email protected]> * Inject autoconfiguration in the Spring Boot 3 style (#831) * Bump from spring boot 2.3.5.RELEASE to 2.7.8 Signed-off-by: Sergio <[email protected]> (cherry picked from commit 9152c91) * Ensure old versions of spring boot are still compatible Signed-off-by: Sergio <[email protected]> --------- Signed-off-by: champel <[email protected]> Signed-off-by: Sergio <[email protected]> Signed-off-by: MregXN <[email protected]> * Bump from reactor 2.3.5.RELEASE to 2.7.8 (#830) * Bump from reactor 2.3.5.RELEASE to 2.7.8 Signed-off-by: Sergio <[email protected]> * Simplification Signed-off-by: Sergio <[email protected]> --------- Signed-off-by: Sergio <[email protected]> Signed-off-by: MregXN <[email protected]> * rerun checks Signed-off-by: MregXN <[email protected]> * modify the way of grpc server starts Signed-off-by: MregXN <[email protected]> * modify README Signed-off-by: MregXN <[email protected]> * Update pom.xml Signed-off-by: MregXN <[email protected]> --------- Signed-off-by: MregXN <[email protected]> Signed-off-by: Artur Souza <[email protected]> Signed-off-by: champel <[email protected]> Signed-off-by: Sergio <[email protected]> Signed-off-by: MregXN <[email protected]> Co-authored-by: Artur Souza <[email protected]> Co-authored-by: champel <[email protected]> Co-authored-by: Mukundan Sundararajan <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * auto validate actors (#863) Signed-off-by: Mukundan Sundararajan <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Bump codecov/codecov-action from 3.1.1 to 3.1.4 (#862) Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 3.1.1 to 3.1.4. - [Release notes](https://github.com/codecov/codecov-action/releases) - [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md) - [Commits](codecov/codecov-action@v3.1.1...v3.1.4) --- updated-dependencies: - dependency-name: codecov/codecov-action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: Mahmut Canga <[email protected]> * Fix 787 (#832) * prepare before testing * Update tests * fix checkstyle --------- Co-authored-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Upgrade to 1.11 RCs. (#867) Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Init for workflows Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Updating some javadocs and Years. Signed-off-by: Hannah Kennedy <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Add missing Header Signed-off-by: Hannah Kennedy <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * respond to PR feedback Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Update workflow example README Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Address PR feedback Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * fixup deprecated pom.xml variable Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Updates based on PR feedback Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Update pom files per feedback Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * GetInstanceState implementation (#1) * addiny getInstanceMetadata, waitForInstanceStart and waitForInstanceCompletion implementation --------- Co-authored-by: aymanmahmoud_microsoft <[email protected]> Signed-off-by: Aymand Mahmoud <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Management API Signed-off-by: Mahmut Canga <[email protected]> * remove try/catch Signed-off-by: Mahmut Canga <[email protected]> * implementing getIsReplaying() method for Authoring API (#7) Co-authored-by: Julio Rezende <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> Signed-off-by: Julio Rezende <[email protected]> * Implementing getCurrentInstant() authoring method (#5) Co-authored-by: Julio Rezende <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> Signed-off-by: Julio Rezende <[email protected]> * Activity Implementation (#3) Signed-off-by: Mahmut Canga <[email protected]> * fixing issue with getIsReplaying() call (#8) Co-authored-by: Julio Rezende <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> Signed-off-by: Julio Rezende <[email protected]> * Generate updated javadocs for 1.9.0 (#878) * Generate updated javadocs for 1.9.0 Signed-off-by: Artur Souza <[email protected]> * Update _index.md Signed-off-by: Artur Souza <[email protected]> --------- Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Add .sdkmanrc config file and JDK installation instructions (#873) * Add .sdkmanrc file with installation instructions Signed-off-by: Emanuel Alves <[email protected]> * Update README.md Signed-off-by: Artur Souza <[email protected]> --------- Signed-off-by: Emanuel Alves <[email protected]> Signed-off-by: Artur Souza <[email protected]> Co-authored-by: Artur Souza <[email protected]> Co-authored-by: Artur Souza <[email protected]> Co-authored-by: Mukundan Sundararajan <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Add unit testing example Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * implementing getIsReplaying() method for Authoring API (#7) Co-authored-by: Julio Rezende <[email protected]> Signed-off-by: Julio Rezende <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * fix parent pom Signed-off-by: Mahmut Canga <[email protected]> * Send Event Implementation (#10) Signed-off-by: Mahmut Canga <[email protected]> * Implementing allOf, anyOf, createTimer methods (#11) Co-authored-by: Julio Rezende <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> Co-authored-by: Julio Rezende <[email protected]> * Support remote endpoint. (#877) * Support remote endpoint. Signed-off-by: Artur Souza <[email protected]> * Use GRPC_ENDPOINT and HTTP_ENDPOINT in integration tests. Signed-off-by: Artur Souza <[email protected]> * Fix happy path for waiting for sidecar test. Signed-off-by: Artur Souza <[email protected]> --------- Signed-off-by: Artur Souza <[email protected]> Co-authored-by: Mukundan Sundararajan <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * Add callSubWorkflow Implementation Co-authored-by: Aymand Mahmoud <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> Signed-off-by: Aymand Mahmoud <[email protected]> * rename DemoSubWorkflow Co-authored-by: Aymand Mahmoud <[email protected]> Signed-off-by: Aymand Mahmoud <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * continueAsNew Implementation (#13) Signed-off-by: Mahmut Canga <[email protected]> * remove duplicate class Signed-off-by: Mahmut Canga <[email protected]> * add missing mockito test dependency Signed-off-by: Mahmut Canga <[email protected]> * use new workflow client implementation Signed-off-by: Mahmut Canga <[email protected]> * moved implementations to new workflow and context Signed-off-by: Mahmut Canga <[email protected]> * relocate duplicate implemantation Signed-off-by: Mahmut Canga <[email protected]> * remove duplicate test and increase test coverage Signed-off-by: Mahmut Canga <[email protected]> * Implement retry and timeout policy for gRPC client. (#889) * Implement retry and timeout policy for gRPC client. Signed-off-by: Artur Souza <[email protected]> * Fix invoke actor after aborted flow. Signed-off-by: Artur Souza <[email protected]> --------- Signed-off-by: Artur Souza <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> * renamed getIsReplaying Signed-off-by: Mahmut Canga <[email protected]> * rollback changes on client Signed-off-by: Mahmut Canga <[email protected]> * move workflow runtime state package Signed-off-by: Mahmut Canga <[email protected]> * rename workflow instance state to status Signed-off-by: Mahmut Canga <[email protected]> * remove unnecessary else Signed-off-by: Mahmut Canga <[email protected]> * removed unknown state Signed-off-by: Mahmut Canga <[email protected]> * updated comment Signed-off-by: Mahmut Canga <[email protected]> * updated workflow failure details Signed-off-by: Mahmut Canga <[email protected]> * fix style issues Signed-off-by: Mahmut Canga <[email protected]> * rollback merge change Signed-off-by: Mahmut Canga <[email protected]> * fixed pom files Signed-off-by: Mahmut Canga <[email protected]> * rollback actors pom changes on autoformat Signed-off-by: Mahmut Canga <[email protected]> * fixe actors pom Signed-off-by: Mahmut Canga <[email protected]> * fix styling on actors pom Signed-off-by: Mahmut Canga <[email protected]> * fix pom spacing Signed-off-by: Mahmut Canga <[email protected]> * move test to match the package Signed-off-by: Mahmut Canga <[email protected]> * add missing dependencies Signed-off-by: Mahmut Canga <[email protected]> * increased test coverage Signed-off-by: Mahmut Canga <[email protected]> * moved workflow runtime package Signed-off-by: Mahmut Canga <[email protected]> * add exception for missing case Signed-off-by: Mahmut Canga <[email protected]> * add null check for metadata Signed-off-by: Mahmut Canga <[email protected]> * add runtime exception error messages Signed-off-by: Mahmut Canga <[email protected]> * update try catch scope Signed-off-by: Mahmut Canga <[email protected]> * update activity definition to an interface Signed-off-by: Mahmut Canga <[email protected]> * update comments Signed-off-by: Mahmut Canga <[email protected]> * removed redundant method Signed-off-by: Mahmut Canga <[email protected]> * PR updates Signed-off-by: Mahmut Canga <[email protected]> --------- Signed-off-by: LionTao <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Artur Souza <[email protected]> Signed-off-by: champel <[email protected]> Signed-off-by: Sergio <[email protected]> Signed-off-by: MregXN <[email protected]> Signed-off-by: MregXN <[email protected]> Signed-off-by: Mukundan Sundararajan <[email protected]> Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Hannah Kennedy <[email protected]> Signed-off-by: Bill DeRusha <[email protected]> Signed-off-by: Aymand Mahmoud <[email protected]> Signed-off-by: Julio Rezende <[email protected]> Signed-off-by: Emanuel Alves <[email protected]> Signed-off-by: Mahmut Canga <[email protected]> Co-authored-by: LionTao <[email protected]> Co-authored-by: Mukundan Sundararajan <[email protected]> Co-authored-by: Artur Souza <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: champel <[email protected]> Co-authored-by: MregXN <[email protected]> Co-authored-by: MatejNedic <[email protected]> Co-authored-by: Bill DeRusha <[email protected]> Co-authored-by: Hannah Kennedy <[email protected]> Co-authored-by: Bill DeRusha <[email protected]> Co-authored-by: Aymalla <[email protected]> Co-authored-by: aymanmahmoud_microsoft <[email protected]> Co-authored-by: swetakumari <[email protected]> Co-authored-by: julio <[email protected]> Co-authored-by: Julio Rezende <[email protected]> Co-authored-by: Emanuel Alves <[email protected]> Co-authored-by: Artur Souza <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the proposal
What were the steps followed to generate the protobuf classes?
The text was updated successfully, but these errors were encountered: