Use state serializer content type when saving actor states.

[antoniomaria]

Description

Use state serializer content type when saving dapr states.

Issue reference

Please reference the issue this PR will close: #1031

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

• Code compiles correctly
• Created/updated tests
• Extended the documentation

[artursouza]

I am want to take this PR, although it is a breaking change.

[antoniomaria]

Be my guest. Thanks for take it.

[antoniomaria]

Did I understand correctly that @artursouza will take this PR to the goal?
Or Can I still do something? like fixing Integration tests, or documentation?

[mukundansundar]

@artursouza Qq if state serializer is used when serializing, shouldn't there be an option during desirialization as well?
Also do you think serializer option could be part of StateOptions? useCustomSerializer or useStateSerializer, and that could be used during both Save and Get State also?

[artursouza]

@artursouza Qq if state serializer is used when serializing, shouldn't there be an option during desirialization as well? Also do you think serializer option could be part of StateOptions? useCustomSerializer or useStateSerializer, and that could be used during both Save and Get State also?

Can you elaborate because this PR is just about setting the content type.

[artursouza]

Did I understand correctly that @artursouza will take this PR to the goal? Or Can I still do something? like fixing Integration tests, or documentation?

Sorry for the ambiguity. By taking this PR, I meant accepting it. But the validation is failing.

[antoniomaria]

Did I understand correctly that @artursouza will take this PR to the goal? Or Can I still do something? like fixing Integration tests, or documentation?

Sorry for the ambiguity. By taking this PR, I meant accepting it. But the validation is failing.

Ah sorry, I missed your answer. Perhaps some NPE exception somewhere, I can have a look

[antoniomaria]

Dapr side car doesn't seem to like the content type if the state is null. I checked for it. Please review @artursouza

[antoniomaria]

@mukundansundar did you have time to review this MR?

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.66%. Comparing base (d759c53) to head (0dac76a).
Report is 27 commits behind head on master.

❗ Current head 0dac76a differs from pull request most recent head 6425151

Please upload reports for the commit 6425151 to get more accurate results.

Additional details and impacted files

@@             Coverage Diff              @@
##             master    #1033      +/-   ##
============================================
+ Coverage     76.91%   77.66%   +0.74%     
+ Complexity     1592     1572      -20     
============================================
  Files           145      144       -1     
  Lines          4843     4768      -75     
  Branches        562      554       -8     
============================================
- Hits           3725     3703      -22     
+ Misses          821      780      -41     
+ Partials        297      285      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[antoniomaria]

I don't see the button "Merge PR", is it because the branch is out of date? or because I don't have access to merge a PR ?

[cicoyle]

Only maintainers have the ability to merge - cc: @artursouza plz take another pass

[marcduiker]

@holopin-bot @antoniomaria Thank you!

[holopin-bot]

Congratulations @antoniomaria, the maintainer of this repository has issued you a badge! Here it is: https://holopin.io/claim/clzva93ay23590cihiek76he3

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!