Removing Saga from Dapr Workflows #1216
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@artursouza @cicoyle and @salaboy please take a look. This PR is based on our discussion in Discord that has been started by @olitomlinson. The PR is mostly about removing code. |
|
For reference this PR is based on this discussion: dapr/proposals#47 (comment) |
cicoyle
previously approved these changes
Feb 20, 2025
|
@artursouza could you please approve and merge. Thank you! |
artursouza
previously approved these changes
Feb 28, 2025
added 2 commits
February 28, 2025 14:42
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
artur-ciocanu
dismissed stale reviews from artursouza and cicoyle
via
940110b
artur-ciocanu
force-pushed
the
gh-1215
branch
from
8878019 to
940110b
Compare
|
@artursouza I will need your blessing on this PR again, since I had to fix the Testcontainer tests. |
Signed-off-by: Artur Ciocanu <[email protected]>
artursouza
approved these changes
Feb 28, 2025
|
@artursouza all the checks are 🟢 could you please merge. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removing Saga from Dapr Workflows
Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1215
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: