Skip to content

Spring boot workflow patterns examples with mechanical markdown and tests #1377

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
May 21, 2025
Merged

Spring boot workflow patterns examples with mechanical markdown and tests #1377

merged 24 commits into from
May 21, 2025

Conversation

salaboy
Copy link
Collaborator

@salaboy salaboy commented May 16, 2025 •
edited
Loading

Description

Adding separate module for Workflow Patterns

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #1344

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

  • Code compiles correctly
  • Created/updated tests
  • Extended the documentation

@salaboy salaboy requested review from a team as code owners May 16, 2025 09:06
@salaboy salaboy force-pushed the adding-wf-examples-to-sb branch 3 times, most recently from 4008dcd to cacbe04 Compare May 16, 2025 11:36
@salaboy salaboy changed the title [WIP] Spring boot workflow patterns initial version Spring boot workflow patterns initial version May 16, 2025
@salaboy salaboy changed the title Spring boot workflow patterns initial version Spring boot workflow patterns examples with mechanical markdown and tests May 16, 2025
@salaboy
Copy link
Collaborator Author

salaboy commented May 16, 2025

@dapr/maintainers-java-sdk please review and add suggestions if you have them.

@salaboy salaboy force-pushed the adding-wf-examples-to-sb branch 2 times, most recently from e275c5f to abf72c4 Compare May 16, 2025 14:36
cicoyle
cicoyle reviewed May 16, 2025
View reviewed changes
@salaboy salaboy force-pushed the adding-wf-examples-to-sb branch from 8374edf to aa7e980 Compare May 17, 2025 10:01
@salaboy
Copy link
Collaborator Author

salaboy commented May 17, 2025

@dapr/maintainers-java-sdk all comments addressed, please re review

@salaboy salaboy mentioned this pull request May 17, 2025
Closed
siri-varma
siri-varma reviewed May 19, 2025
View reviewed changes
siri-varma
siri-varma reviewed May 19, 2025
View reviewed changes
siri-varma
siri-varma reviewed May 19, 2025
View reviewed changes
siri-varma
siri-varma reviewed May 19, 2025
View reviewed changes
siri-varma
siri-varma reviewed May 19, 2025
View reviewed changes
siri-varma
siri-varma reviewed May 19, 2025
View reviewed changes
siri-varma
siri-varma reviewed May 19, 2025
View reviewed changes
siri-varma
siri-varma reviewed May 19, 2025
View reviewed changes
siri-varma
siri-varma reviewed May 19, 2025
View reviewed changes
cicoyle and others added 20 commits May 21, 2025 15:27
@cicoyle @javier-aliaga @salaboy
Feat Add TLS & mTLS support for gRPC with root CA and insecure mode (d…
6d8fdf1 
…apr#1361)

* feat: Support for GRPC ssl

Signed-off-by: Javier Aliaga <[email protected]>

* add tests

Signed-off-by: Cassandra Coyle <[email protected]>

* fix CI

Signed-off-by: Cassandra Coyle <[email protected]>

* add back else if

Signed-off-by: Cassandra Coyle <[email protected]>

* channel cleanup

Signed-off-by: Cassandra Coyle <[email protected]>

* add root ca support

Signed-off-by: Cassandra Coyle <[email protected]>

* checkstyles

Signed-off-by: Cassandra Coyle <[email protected]>

* add insecure

Signed-off-by: Cassandra Coyle <[email protected]>

* fix checkstyles

Signed-off-by: Cassandra Coyle <[email protected]>

* use InsecureTrustManagerFactory

Signed-off-by: Cassandra Coyle <[email protected]>

* fix test

Signed-off-by: Cassandra Coyle <[email protected]>

---------

Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Co-authored-by: Javier Aliaga <[email protected]>
Signed-off-by: salaboy <[email protected]>
@salaboy
spring boot workflow patterns initial version
86efd21 
Signed-off-by: salaboy <[email protected]>
@salaboy
adding README for workflows
d62d007 
Signed-off-by: salaboy <[email protected]>
@salaboy
adding child example
dd113b8 
Signed-off-by: salaboy <[email protected]>
@salaboy
updating examples to work with markdown tests
d29c712 
Signed-off-by: salaboy <[email protected]>
@salaboy
running mechanical markdown for workflow examples
ca95b62 
Signed-off-by: salaboy <[email protected]>
@siri-varma @mcruzdev
@artur-ciocanu @cicoyle @dependabot @dapr-bot @javier-aliaga @salaboy
Fix the issue with retries not happening correctly for Activities and…
52adff6 
… Workflows (dapr#1343)

* Add coverage for some properties (dapr#1297)

Signed-off-by: sirivarma <[email protected]>

* Make the DAPR version being used consistent across all tests (dapr#1299)

Signed-off-by: sirivarma <[email protected]>

* Separate Dapr constants from IT container constants (dapr#1315)

Signed-off-by: Artur Ciocanu <[email protected]>
Co-authored-by: Artur Ciocanu <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Use Java Bean for connection details and add more tests (dapr#1317)

* Use Java Bean for connection details and add more tests

Signed-off-by: Artur Ciocanu <[email protected]>

* Simplify mock setup

Signed-off-by: Artur Ciocanu <[email protected]>

* Adding even more tests for test coverage

Signed-off-by: Artur Ciocanu <[email protected]>

---------

Signed-off-by: Artur Ciocanu <[email protected]>
Co-authored-by: Artur Ciocanu <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Update CONTRIBUTING.md

Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Bump codecov/codecov-action from 5.4.0 to 5.4.2 (dapr#1318)

Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.4.0 to 5.4.2.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v5.4.0...v5.4.2)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-version: 5.4.2
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cassie Coyle <[email protected]>
Co-authored-by: Dapr Bot <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Fix URL building logic (dapr#1320)

* Fix URL building logic

Signed-off-by: Artur Ciocanu <[email protected]>

* Add test for query params

Signed-off-by: Artur Ciocanu <[email protected]>

* Fix the assertion in the test

Signed-off-by: Artur Ciocanu <[email protected]>

* Adjust the tests

Signed-off-by: Artur Ciocanu <[email protected]>

* Remove uneeded changes from IT test

Signed-off-by: Artur Ciocanu <[email protected]>

* Revert some unintended changes

Signed-off-by: Artur Ciocanu <[email protected]>

* Simplify the testing a little bit

Signed-off-by: Artur Ciocanu <[email protected]>

* Adjust the test to use ServerRequest

Signed-off-by: Artur Ciocanu <[email protected]>

* Test removing things from method invoke controller

Signed-off-by: Artur Ciocanu <[email protected]>

* Add query param encoding test

Signed-off-by: Artur Ciocanu <[email protected]>

* Revert some unintended changes

Signed-off-by: Artur Ciocanu <[email protected]>

* Some tiny styles

Signed-off-by: Artur Ciocanu <[email protected]>

---------

Signed-off-by: Artur Ciocanu <[email protected]>
Co-authored-by: Artur Ciocanu <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Generate updated javadocs for 1.14.1

Signed-off-by: Dapr Bot <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Add Conversation AI to Java SDK (dapr#1235)

* Conversation first commit

Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Signed-off-by: siri-varma <[email protected]>

* Add unit tests

Signed-off-by: sirivarma <[email protected]>
Signed-off-by: siri-varma <[email protected]>

* change ai to conv

Signed-off-by: sirivarma <[email protected]>
Signed-off-by: siri-varma <[email protected]>

* Move to single module

Signed-off-by: sirivarma <[email protected]>
Signed-off-by: siri-varma <[email protected]>

* Remove module

Signed-off-by: sirivarma <[email protected]>
Signed-off-by: siri-varma <[email protected]>

* Add Integration tests

Signed-off-by: siri-varma <[email protected]>

* Update sdk-tests/src/test/java/io/dapr/it/testcontainers/DaprConversationIT.java

Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: siri-varma <[email protected]>

* Fix things

Signed-off-by: siri-varma <[email protected]>

* Address comments

Signed-off-by: siri-varma <[email protected]>

* Import tag

Signed-off-by: siri-varma <[email protected]>

* Address comments

Signed-off-by: siri-varma <[email protected]>

* Make common config

Signed-off-by: siri-varma <[email protected]>

* Address comments

Signed-off-by: siri-varma <[email protected]>

* fix constant

Signed-off-by: siri-varma <[email protected]>

* fix constant

Signed-off-by: siri-varma <[email protected]>

* fix constant

Signed-off-by: siri-varma <[email protected]>

* fix s

Signed-off-by: siri-varma <[email protected]>

* Fix things

Signed-off-by: siri-varma <[email protected]>

* Fix things

Signed-off-by: siri-varma <[email protected]>

* Fix things

Signed-off-by: siri-varma <[email protected]>

* Make common config

Signed-off-by: siri-varma <[email protected]>

* Update README.md

Signed-off-by: Siri Varma Vegiraju <[email protected]>

* Update README.md

Signed-off-by: Siri Varma Vegiraju <[email protected]>

---------

Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: sirivarma <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Add docs for usage of Jobs SDK (dapr#1323)

* Add doc for jobs

Signed-off-by: siri-varma <[email protected]>

* Add docs for Jobs

Signed-off-by: siri-varma <[email protected]>

* Apply suggestions from code review

Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>

---------

Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Co-authored-by: artur-ciocanu <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Use dapr/durabletask-java (dapr#1336)

* microsoft durabletask-java -> dapr durabletask-java

Signed-off-by: Cassandra Coyle <[email protected]>

* update another ref

Signed-off-by: Cassandra Coyle <[email protected]>

* 1.5.2 release

Signed-off-by: Cassandra Coyle <[email protected]>

* fix import order

Signed-off-by: Cassandra Coyle <[email protected]>

* Sdk new changes

Signed-off-by: siri-varma <[email protected]>

* Refine workflows

Signed-off-by: siri-varma <[email protected]>

* add ;

Signed-off-by: Cassandra Coyle <[email protected]>

* rm try

Signed-off-by: Cassandra Coyle <[email protected]>

---------

Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Co-authored-by: siri-varma <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Update master version to 1.16.0-SNAPSHOT

Signed-off-by: Dapr Bot <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Fix NPE

Signed-off-by: siri-varma <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Fix NPE

Signed-off-by: siri-varma <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Fix NPE

Signed-off-by: siri-varma <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Fix NPE

Signed-off-by: siri-varma <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Fix NPE

Signed-off-by: siri-varma <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Fix NPE

Signed-off-by: siri-varma <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Fix things

Signed-off-by: siri-varma <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Renaming and exposing connection details (dapr#1341)

Signed-off-by: Artur Ciocanu <[email protected]>
Co-authored-by: Artur Ciocanu <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* [Master] Fix Vulnerabilities (dapr#1354)

* update okio

Signed-off-by: Cassandra Coyle <[email protected]>

* rm unused dep

Signed-off-by: Cassandra Coyle <[email protected]>

---------

Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Feat Add TLS & mTLS support for gRPC with root CA and insecure mode (dapr#1361)

* feat: Support for GRPC ssl

Signed-off-by: Javier Aliaga <[email protected]>

* add tests

Signed-off-by: Cassandra Coyle <[email protected]>

* fix CI

Signed-off-by: Cassandra Coyle <[email protected]>

* add back else if

Signed-off-by: Cassandra Coyle <[email protected]>

* channel cleanup

Signed-off-by: Cassandra Coyle <[email protected]>

* add root ca support

Signed-off-by: Cassandra Coyle <[email protected]>

* checkstyles

Signed-off-by: Cassandra Coyle <[email protected]>

* add insecure

Signed-off-by: Cassandra Coyle <[email protected]>

* fix checkstyles

Signed-off-by: Cassandra Coyle <[email protected]>

* use InsecureTrustManagerFactory

Signed-off-by: Cassandra Coyle <[email protected]>

* fix test

Signed-off-by: Cassandra Coyle <[email protected]>

---------

Signed-off-by: Javier Aliaga <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Co-authored-by: Javier Aliaga <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Address comments

Signed-off-by: siri-varma <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Fix things

Signed-off-by: siri-varma <[email protected]>
Signed-off-by: sirivarma <[email protected]>

* Fix things

Signed-off-by: siri-varma <[email protected]>
Signed-off-by: sirivarma <[email protected]>

---------

Signed-off-by: sirivarma <[email protected]>
Signed-off-by: Artur Ciocanu <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Dapr Bot <[email protected]>
Signed-off-by: Siri Varma Vegiraju <[email protected]>
Signed-off-by: siri-varma <[email protected]>
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: Javier Aliaga <[email protected]>
Co-authored-by: Matheus Cruz <[email protected]>
Co-authored-by: artur-ciocanu <[email protected]>
Co-authored-by: Artur Ciocanu <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dapr Bot <[email protected]>
Co-authored-by: Dapr Bot <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Co-authored-by: Javier Aliaga <[email protected]>
Signed-off-by: salaboy <[email protected]>
@cicoyle @salaboy
1.5.4 (dapr#1375)
f3f8d23 
Signed-off-by: Cassandra Coyle <[email protected]>
Signed-off-by: salaboy <[email protected]>
@salaboy
fixing order Id correlation
861b6d7 
Signed-off-by: salaboy <[email protected]>
@salaboy
fixing waiting time for tests to run
8284edb 
Signed-off-by: salaboy <[email protected]>
@salaboy
fixing app name
7d0fdc8 
Signed-off-by: salaboy <[email protected]>
@salaboy
adding app name and removing log lines
2f3769a 
Signed-off-by: salaboy <[email protected]>
@dependabot @salaboy
Bump codecov/codecov-action from 5.4.2 to 5.4.3 (dapr#1379)
ba6764d 
Bumps [codecov/codecov-action](https://github.com/codecov/codecov-action) from 5.4.2 to 5.4.3.
- [Release notes](https://github.com/codecov/codecov-action/releases)
- [Changelog](https://github.com/codecov/codecov-action/blob/main/CHANGELOG.md)
- [Commits](codecov/codecov-action@v5.4.2...v5.4.3)

---
updated-dependencies:
- dependency-name: codecov/codecov-action
  dependency-version: 5.4.3
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: salaboy <[email protected]>
@dependabot @cicoyle @salaboy
Bump fossas/fossa-action from 1.6.0 to 1.7.0 (dapr#1380)
7638ae9 
Bumps [fossas/fossa-action](https://github.com/fossas/fossa-action) from 1.6.0 to 1.7.0.
- [Release notes](https://github.com/fossas/fossa-action/releases)
- [Commits](fossas/fossa-action@v1.6.0...v1.7.0)

---
updated-dependencies:
- dependency-name: fossas/fossa-action
  dependency-version: 1.7.0
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: salaboy <[email protected]>
@iddeepak @cicoyle
@artur-ciocanu @salaboy
Fix component spec parsing (dapr#1370)
8fb6698 
* Fix component spec parsing

Signed-off-by: Deepak <[email protected]>

* Fix component spec parsing

Signed-off-by: Deepak <[email protected]>

* Fix component spec metadata parsing

Signed-off-by: Deepak <[email protected]>

* fix checkstyle-error

Signed-off-by: Deepak <[email protected]>

---------

Signed-off-by: Deepak <[email protected]>
Co-authored-by: Cassie Coyle <[email protected]>
Co-authored-by: artur-ciocanu <[email protected]>
Signed-off-by: salaboy <[email protected]>
@salaboy @cicoyle
Update spring-boot-examples/workflows/README.md
cc11f6c 
Co-authored-by: Cassie Coyle <[email protected]>
Signed-off-by: salaboy <[email protected]>
@salaboy
fixing comments
c320c20 
Signed-off-by: salaboy <[email protected]>
@artur-ciocanu @salaboy
Update body.json
cd68f72 
Signed-off-by: artur-ciocanu <[email protected]>
Signed-off-by: salaboy <[email protected]>
@artur-ciocanu @salaboy
Update FanOutInWorkflow.java
780c7a2 
Signed-off-by: artur-ciocanu <[email protected]>
Signed-off-by: salaboy <[email protected]>
@salaboy
clean up logs for multiple executions, for standalone mode
f143cb9 
Signed-off-by: salaboy <[email protected]>
@salaboy salaboy force-pushed the adding-wf-examples-to-sb branch from 5750c37 to f143cb9 Compare May 21, 2025 13:27
@artur-ciocanu
Copy link
Contributor

@cicoyle the PR looks good to me, do you have any outstanding comments or I can mark it as auto-merge.

artur-ciocanu
artur-ciocanu approved these changes May 21, 2025
View reviewed changes
Copy link
Contributor

@artur-ciocanu artur-ciocanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! ❤️

@cicoyle cicoyle merged commit 1e4bcf9 into dapr:master May 21, 2025
9 checks passed
@codecov Codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 95.28796% with 9 lines in your changes missing coverage. Please review.

Project coverage is 78.12%. Comparing base (d759c53) to head (d0fca45).
Report is 151 commits behind head on master.

Files with missing lines Patch % Lines
...boot/examples/wfp/WorkflowPatternsApplication.java 33.33% 2 Missing ⚠️
...ot/examples/wfp/continueasnew/CleanUpActivity.java 83.33% 2 Missing ⚠️
...ot/examples/wfp/externalevent/ApproveActivity.java 77.77% 2 Missing ⚠️
...gboot/examples/wfp/externalevent/DenyActivity.java 77.77% 2 Missing ⚠️
...mples/wfp/continueasnew/ContinueAsNewWorkflow.java 92.85% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #1377      +/-   ##
============================================
+ Coverage     76.91%   78.12%   +1.20%     
- Complexity     1592     1831     +239     
============================================
  Files           145      223      +78     
  Lines          4843     5663     +820     
  Branches        562      601      +39     
============================================
+ Hits           3725     4424     +699     
- Misses          821      919      +98     
- Partials        297      320      +23

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artur-ciocanu artur-ciocanu artur-ciocanu approved these changes

@siri-varma siri-varma siri-varma approved these changes

@cicoyle cicoyle cicoyle approved these changes

@iddeepak iddeepak iddeepak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

SpringBoot Workflow Examples
5 participants
@salaboy @artur-ciocanu @siri-varma @cicoyle @iddeepak