Skip to content

Make 'rm -f *' during compilation optional #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davidzwa opened this issue Jan 16, 2020 · 2 comments
Closed

Make 'rm -f *' during compilation optional #14

davidzwa opened this issue Jan 16, 2020 · 2 comments

Comments

@davidzwa
Copy link

davidzwa commented Jan 16, 2020 •
edited
Loading

We are considering using this image to build our debugging version of the app, but currently all compilation .o-objects are removed making the process really slow.

Is it possible to add a flag SKIP_REMOVE to not remove all objects in the volume and thus speed up builds for development purposes?

We can take care of removing the unused .o objects ourselves (make command) thus giving back control to the developer.
darkmattercoder added a commit that referenced this issue Jan 16, 2020
@darkmattercoder
remove build dir cleaning in the default build entrypoint
359dcf5 
Background:

To give developers more control back about their build process, I decided because of #14, that the build directory should not get cleaned by default.
This should even be something that the docker image should not take care of at all. Close #14
@darkmattercoder
Copy link
Owner

You are right. The developer should be in control of the build dir cleaning. Fix should reach master after successful pipeline process.

@davidzwa
Copy link
Author

You deserve absolute praise for this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@darkmattercoder @davidzwa