Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

[Guiness] ddescribe supported #1029

Closed
vicb opened this issue May 10, 2014 · 7 comments · Fixed by #1032
Closed

[Guiness] ddescribe supported #1029

vicb opened this issue May 10, 2014 · 7 comments · Fixed by #1032

Comments

@vicb
Copy link
Contributor

vicb commented May 10, 2014

@vsavkin we used to be able to use ddescribe in place of describe it would have the same effect as iit on a group of test. It seems it doesn't work any more, could you take a look at this ?
(I haven't tried but I think xdescribe was supported before, is it still supported now ?)

Thanks

@vsavkin
Copy link
Contributor

vsavkin commented May 10, 2014

xdescribe, and xit should work.

ddescribe works the same way it works in Jasmine, which is different from how, for instance, solo_group works in unittest.

The way it works in Jasmine:

  1. If there are no ddescribe or iit blocks, all the tests get run.
  2. If there are ddescribe blocks, only these blocks get run.
  3. If there are iit blocks, ddescribe blocks get ignored. So only the iit blocks get run.

For instance,

    ddescribe("A", () {
        it("test A1", () {});
        it("test A2", () {})
    });

    describe("B", () {
        iit("test B1", () {});
        it("test B2", () {})
    });

will run only test B1.

This is the way it is working right now in Guinness (to mimic Jasmine, and I also find this way better).

Does it work like this for you? If it does, is it a problem?

Thank you,
Victor

@vicb
Copy link
Contributor Author

vicb commented May 10, 2014

It think my uc is #2 but all the suite is executed instead of ddescribe tests only

(IIRC we have xit tests)

@vsavkin
Copy link
Contributor

vsavkin commented May 10, 2014

I tried a few specs, and ddescribe worked correctly. Can you send me the name of the file you are trying to run, so I can continue troubleshooting?

@vicb
Copy link
Contributor Author

vicb commented May 11, 2014

Must have been date-spec.dart. thanks for looking into this.

On May 11, 2014 1:09:30 AM CEST, Victor Savkin [email protected] wrote:

I tried a few specs, and ddescribe worked correctly. Can you send me
the name of the file you are trying to run, so I can continue
troubleshooting?


Reply to this email directly or view it on GitHub:
#1029 (comment)

@vsavkin
Copy link
Contributor

vsavkin commented May 11, 2014

I've pushed a version of guinness (v0.1.3) that fixes the issue.

To upgrade Guinness in the Angular project you will have to change pubspec.lock. If you want I can create a PR with the changes to the pubspec.lock file.

@vicb
Copy link
Contributor Author

vicb commented May 11, 2014

Thanks Victor. Yes please submit a PR that "closes" this issue.

vsavkin added a commit to vsavkin/angular.dart that referenced this issue May 11, 2014
Upgrade the Guinness library to fix the issue with `ddescribe` not working.

Closes dart-archive#1029
@vsavkin
Copy link
Contributor

vsavkin commented May 11, 2014

@vicb Just submitted PR #1032.

vicb pushed a commit that referenced this issue May 12, 2014
Upgrade the Guinness library to fix the issue with `ddescribe` not working.

Closes #1029
jbdeboer pushed a commit that referenced this issue May 20, 2014
Upgrade the Guinness library to fix the issue with `ddescribe` not working.

Closes #1029

Conflicts:
	pubspec.lock
	pubspec.yaml
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
Upgrade the Guinness library to fix the issue with `ddescribe` not working.

Closes dart-archive#1029
dsalsbury pushed a commit to dsalsbury/angular.dart that referenced this issue Jul 16, 2014
Upgrade the Guinness library to fix the issue with `ddescribe` not working.

Closes dart-archive#1029
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants