This repository was archived by the owner on Nov 1, 2024. It is now read-only.
Changes for landing https://github.com/dart-lang/sdk/issues/32161 #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add void declarations to methods with implicit dynamic returning void values, which may be illegal in dart 2, but in either case, expresses the current intent better.
|
lgtm! Will this package need to be re-published? |
devoncarew
approved these changes
Feb 19, 2018
|
Since this is just a test, no, but we will need to pull it in to g3, so a publish is, strictly speaking, more compliant than a random commit hash. Your call if you want to go through the work there, let me know what you decide and I'll do the g3 sync |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Oct 25, 2024
…id-fixes Changes for landing dart-lang/sdk#32161
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add void declarations to methods with implicit dynamic returning void
values, which may be illegal in dart 2, but in either case, expresses
the current intent better.