Skip to content
This repository was archived by the owner on Feb 10, 2025. It is now read-only.

fix the unit tests for Dart 3.0 #86

Merged
merged 2 commits into from
Dec 12, 2022
Merged

fix the unit tests for Dart 3.0 #86

merged 2 commits into from
Dec 12, 2022

Conversation

devoncarew
Copy link
Contributor

  • fix the unit tests for Dart 3.0 (make them more lenient towards the exact error text)
  • update to a min. of Dart 2.17.0
  • use the latest package:lints

);
}

// ignore: prefer_expression_function_bodies
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why ignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads better w/o the super long expression bodies :) But I'm not committed to ignoring this lint.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a huge deal either way. Ignore is fine w/ me. just curious

@devoncarew devoncarew merged commit 9cebecd into master Dec 12, 2022
@devoncarew devoncarew deleted the fix_tests_3.0 branch December 12, 2022 22:14
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 10, 2024
* fix the unit tests for Dart 3.0

* update the package version
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants