This repository was archived by the owner on Jan 6, 2025. It is now read-only.
Migrate to null safety #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Towards flutter/devtools#2978 |
| @@ -13,7 +13,7 @@ import 'package:shelf/shelf.dart' as shelf; | |||
| import 'package:stream_channel/stream_channel.dart'; | |||
|
|
|||
| // RFC 2616 requires carriage return delimiters. | |||
| String _sseHeaders(String origin) => 'HTTP/1.1 200 OK\r\n' | |||
| String _sseHeaders(String? origin) => 'HTTP/1.1 200 OK\r\n' | |||
There was a problem hiding this comment.
If origin is null, would "Access-Control-Allow-Origin: null\r\n" would cause problems?
There was a problem hiding this comment.
It shouldn't matter but I updated the logic so that it isn't included.
lib/src/server/sse_handler.dart
Outdated
| @@ -273,11 +273,11 @@ class SseHandler { | |||
| } | |||
| return shelf.Response.ok('', headers: { | |||
| 'access-control-allow-credentials': 'true', | |||
| 'access-control-allow-origin': _originFor(req), | |||
| 'access-control-allow-origin': _originFor(req)!, | |||
There was a problem hiding this comment.
if _originFor returns a String?, should we be force unwrapping it here?
kenzieschmoll
approved these changes
May 11, 2021
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 10, 2024
* Support null safety * update api * review cleanup
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dart-lang/tools#1645