This repository was archived by the owner on Feb 10, 2025. It is now read-only.
Fix JsonDocumentTransformer.bind for dart 2 #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natebosch
reviewed
Apr 16, 2018
pubspec.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: stream_channel | |||
| version: 1.6.4 | |||
| version: 1.6.4+5 | |||
natebosch
approved these changes
Apr 16, 2018
nex3
suggested changes
Apr 16, 2018
CHANGELOG.md
Outdated
| @@ -1,3 +1,8 @@ | |||
| ## 1.6.4+1 | |||
There was a problem hiding this comment.
1.6.5
The + build numbers are only used for pre-1.0.0 packages where the semantics of each version number are shifted to the right.
| var stream = channel.stream.map(_codec.decode); | ||
| var sink = new StreamSinkTransformer.fromHandlers(handleData: (data, sink) { | ||
| var sink = new StreamSinkTransformer.fromHandlers( | ||
| handleData: (Object data, EventSink<String> sink) { |
There was a problem hiding this comment.
Style nit: I generally tend to prefer adding type parameters to the function rather than to callbacks being passed in to the function (e.g. new StreamSinkTransformer<Object, String>.fromHandlers(...)). It saves on tokens (you don't have to write EventSink explicitly) and makes it more obvious what the return type is.
nex3
approved these changes
Apr 16, 2018
|
@nex3 can you publish a version for me? I don't have rights on this package. |
|
Done. |
mosuem
pushed a commit
to dart-lang/tools
that referenced
this pull request
Dec 10, 2024
…-document-transformer-bind Fix JsonDocumentTransformer.bind for dart 2
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the local
sinkdidn't get its generic type inferred properly and you would get runtime errors on certain operations which are difficult to track down.