This repository was archived by the owner on Jul 1, 2023. It is now read-only.

Initial commit of package:flutter_wasm #55

Merged

liamappelbe merged 23 commits into main from flutter3

Oct 29, 2021

Contributor

liamappelbe commented Oct 26, 2021 •

edited

Loading

Only Android is supported at the moment. #40

liamappelbe added 2 commits

October 20, 2021 15:39


          Initial commit of flutter plugin

004b75b


          Clean up

468d50a

liamappelbe requested a review from kevmoo

October 26, 2021 20:28

Contributor Author

liamappelbe commented Oct 26, 2021

@kevmoo How should I set up the github workflows for this pluggin?

Contributor

kevmoo commented Oct 26, 2021

@liamappelbe – you'll have to set up your own workflow for Flutter.

Maybe start at https://github.com/marketplace/actions/flutter-action ?


          Add analysis github action for flutter_wasm

cbeccd8

kevmoo reviewed

View reviewed changes

.github/workflows/test-package.yml Outdated Show resolved Hide resolved

liamappelbe added 2 commits

October 27, 2021 11:58


          Add flutter tests, and use flutter for flutter_analyze

c541b8b


          Loosen Dart SDK requirements

50a8f4e

kevmoo reviewed

View reviewed changes

flutter_wasm/pubspec.yaml Outdated Show resolved Hide resolved

kevmoo reviewed

View reviewed changes

.github/workflows/test-package.yml Outdated Show resolved Hide resolved

kevmoo reviewed

View reviewed changes

.github/workflows/test-package.yml Outdated Show resolved Hide resolved


          Comments

c206b6c

Contributor Author

liamappelbe commented Oct 27, 2021

I don't really understand the [email protected]: Permission denied (publickey). error. Is this because flutter_wasm is currently depending on wasm using a git dependency?

Contributor

kevmoo commented Oct 27, 2021

I don't really understand the [email protected]: Permission denied (publickey). error. Is this because flutter_wasm is currently depending on wasm using a git dependency?

LIkely. Try using an https: dep instead of git@


          Switch from SSH to HTTPS git deps`

de811db

kevmoo reviewed

View reviewed changes

flutter_wasm/example/pubspec.yaml Outdated Show resolved Hide resolved

liamappelbe added 2 commits

October 27, 2021 14:21


          Relative path

bcc7722


          Switch to flutter for analyze action

Contributor Author

liamappelbe commented Oct 28, 2021

I can't repro the analysis failures locally. Why would it not be able to find package:flutter_wasm_example/main.dart?


          also in example!

ab64e36

kevmoo reviewed

View reviewed changes

.github/workflows/test-package.yml

-                    run: flutter pub upgrade
+                    run: |
+                      flutter pub upgrade
+                      flutter pub upgrade --directory example

Contributor

kevmoo Oct 28, 2021

@liamappelbe – now analyze is working – need to run upgrade in both dirs!

liamappelbe added 4 commits

October 28, 2021 12:45


          Run setup script

5a35279


          Install NDK

ccf6b52


          Try the android SDK instead

31c71dc


          Both NDK and SDK?

f56652e

Contributor

kevmoo commented Oct 28, 2021

Getting close!

liamappelbe added 3 commits

October 28, 2021 14:39


          Trying newer versions of tools

b034244


          Trying a different NDK install action

e0d1f01


          Fix yaml

0d73f37

liamappelbe added 5 commits

October 28, 2021 15:05


          Fix arch

980a6c5


          Force install

c1662f0


          Try adding ndkVersion

d3fec90


          Try add-to-path flag

e62d439


          Add NDK to local.properties

8ba697c

Contributor Author

liamappelbe commented Oct 29, 2021

wooo!!!


          Remove probably unnecessary flag from gradle file

2681e01

liamappelbe merged commit fd25783 into main

liamappelbe deleted the flutter3 branch

October 29, 2021 21:27

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet