Skip to content
This repository was archived by the owner on Feb 22, 2018. It is now read-only.

Clarify naming rules for enums #1237

Closed
munificent opened this issue Feb 3, 2015 · 3 comments
Closed

Clarify naming rules for enums #1237

munificent opened this issue Feb 3, 2015 · 3 comments
Labels
EffectiveDart P1

Comments

@munificent
Copy link
Contributor

The style guide does implicitly cover them, but it should be explicit. Under "DO name types using UpperCamelCase", change:

Classes and typedefs...

to:

Classes, enums and typedefs...

Under "PREFER using lowerCamelCase for constant names.", change:

In new code, use lowerCamelCase for constant variables.

to:

In new code, use lowerCamelCase for constant variables, including enum values.

How does that sound?
@kwalrath
Copy link
Contributor

kwalrath commented Feb 3, 2015

sgtm

@kwalrath kwalrath self-assigned this Feb 3, 2015
@kwalrath
Copy link
Contributor

https://chromiumcodereview.appspot.com/959553002

kwalrath added a commit that referenced this issue Feb 26, 2015
@kwalrath
Update the Style Guide
d312ffa 
Staged at:
https://sg-dot-dart-lang.appspot.com/articles/style-guide/

BUG= #1237, #1221, #860
[email protected]

Review URL: https://chromiumcodereview.appspot.com/959553002
@kwalrath
Copy link
Contributor

Fixed: https://www.dartlang.org/articles/style-guide/#do-name-types-using-uppercamelcase

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
EffectiveDart P1
Milestone
No milestone
Development

No branches or pull requests
2 participants
@munificent @kwalrath