Skip to content

Don't assume working directory in tests #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 26, 2015
Merged

Don't assume working directory in tests #242

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions test/chrome_idl_files_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,31 @@
library test_chrome_idl_files;

// TODO: also test test/idl/chrome/*.idl files

import 'dart:io';
import 'dart:mirrors';

import 'package:path/path.dart' as path;
import 'package:test/test.dart';

import '../tool/chrome_idl_parser.dart';
import '../tool/chrome_idl_convert.dart';
import '../tool/chrome_idl_model.dart';

void main() {
final String testDirectory = path.dirname(
currentMirrorSystem().findLibrary(#test_chrome_idl_files).uri.path);

group('ChromeIDLParser', () {
bool idlFileExtTest(FileSystemEntity file) => file.path.endsWith('.idl');

Iterable<FileSystemEntity> chromeIdlFileEntities = new Directory('idl')
.listSync(recursive: false, followLinks: false).where(idlFileExtTest);
Iterable<FileSystemEntity> chromeIdlFileEntities =
new Directory(path.join(testDirectory, '..', 'idl'))
.listSync(recursive: false, followLinks: false)
.where(idlFileExtTest);

Iterable<FileSystemEntity> chromeIdlTestFileEntities =
new Directory('test/idl/chrome')
.listSync(recursive: false, followLinks: false).where(idlFileExtTest);
new Directory(path.join(testDirectory, 'idl', 'chrome'))
.listSync(recursive: false, followLinks: false)
.where(idlFileExtTest);

List<FileSystemEntity> testFileEntities = new List<FileSystemEntity>()
..addAll(chromeIdlFileEntities)
Expand Down
21 changes: 14 additions & 7 deletions test/model_json_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,30 +1,37 @@

library model_json_test;

import 'dart:io';
import 'dart:convert';
import 'dart:io';
import 'dart:mirrors';

import 'package:path/path.dart' as path;
import 'package:test/test.dart';

import '../tool/json_model.dart' as json_model;
import '../tool/json_parser.dart' as json_parser;

void main() {
final String testDirectory = path
.dirname(currentMirrorSystem().findLibrary(#model_json_test).uri.path);

group('json_model', () {
// Define a test for each .json file in idl/
File testFile = new File('idl/extensions/runtime.json');

// The unittest script likes to be run with the cwd set to the project root.
if (testFile.existsSync()) {
Iterable<File> jsonFiles = new Directory('idl')
.listSync(recursive: true, followLinks: false)
.where((f) => f.path.endsWith('.json'));
Iterable<File> jsonFiles =
new Directory(path.join(testDirectory, '..', 'idl'))
.listSync(recursive: true, followLinks: false)
.where((f) => f.path.endsWith('.json'));

for (File file in jsonFiles) {
// skip _api_features.json, _manifest_features.json, _permission_features.json
if (!file.path.contains('/_') && !file.path.contains('test_presubmit')) {
if (!file.path.contains('/_') &&
!file.path.contains('test_presubmit')) {
test(file.path, () {
json_model.JsonNamespace namespace = json_parser.parse(file.readAsStringSync());
json_model.JsonNamespace namespace =
json_parser.parse(file.readAsStringSync());
expect(namespace.namespace, isNotNull);
});
}
Expand Down