Skip to content

Use buildSdkSummary from the analyzer #2746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 6, 2020
Merged

Use buildSdkSummary from the analyzer #2746

merged 4 commits into from
Jul 6, 2020

Conversation

natebosch
Copy link
Member

Fixes #2745

This remains behind a src/ import, but it is the new approach to
building the summary.

Fixes #2745

This remains behind a `src/` import, but it is the new approach to
building the summary.
@natebosch natebosch requested a review from jakemac53 July 6, 2020 20:09
@googlebot googlebot added the cla: yes Google is happy with the PR contributors label Jul 6, 2020
Copy link
Member

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a lot of good cleanup! Dropping yaml, etc...

@natebosch
Copy link
Member Author

@jakemac53 - I haven't manually tested this with flutter - do I need to or are you comfortable with the tests that Travis ran?

Copy link
Contributor

@jakemac53 jakemac53 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am comfortable with the existing test coverage

@natebosch natebosch merged commit 29d321c into master Jul 6, 2020
@natebosch natebosch deleted the build-sdk-summary branch July 6, 2020 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes Google is happy with the PR contributors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: The setter 'useSummary' isn't defined for the class 'FolderBasedDartSdk'.
4 participants