Skip to content

co19/LanguageFeatures/Extension-types/superinterfaces_of_extension_type_A05_t07 bad? #2335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
eernstg opened this issue Oct 30, 2023 · 0 comments
Assignees
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good

Comments

@eernstg
Copy link
Member

eernstg commented Oct 30, 2023

See this comment: dart-lang/sdk#53901 (comment).

I think the getter/setter signature conflict in said test is an accident, we probably just need to add final to that external declaration.

@sgrekhov sgrekhov added the bad-test Report tests in need of updates. When closed, the tests should be considered good label Oct 30, 2023
@sgrekhov sgrekhov self-assigned this Oct 30, 2023
sgrekhov added a commit to sgrekhov/co19 that referenced this issue Oct 30, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this issue Nov 3, 2023
2023-11-02 [email protected] Fixes dart-lang/co19#2344. Add more tests for constants (dart-lang/co19#2345)
2023-11-02 [email protected] dart-lang/co19#1400. Fix static_analysis_extension_types_A10_t03.dart (dart-lang/co19#2328)
2023-11-01 49699333+dependabot[bot]@users.noreply.github.com Bump actions/checkout from 4.1.0 to 4.1.1 (dart-lang/co19#2343)
2023-11-01 [email protected] dart-lang/co19#1400. Add test that extension type and its representation type cannot be in the same constant collection (dart-lang/co19#2341)
2023-10-30 [email protected] Fixes dart-lang/co19#2335. Fix superinterfaces_of_extension_type_A05_t07.dart, add new test expecting an error (dart-lang/co19#2336)
2023-10-26 [email protected] Fixes dart-lang/co19#2333. Representation type can be a subtype of a supertype (dart-lang/co19#2334)

Change-Id: I8531cb4b0e8e3900514f8b0143f918e76f1b0290
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333780
Reviewed-by: Erik Ernst <[email protected]>
Reviewed-by: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bad-test Report tests in need of updates. When closed, the tests should be considered good
Projects
None yet
Development

No branches or pull requests

2 participants