#1399. [Records] Subtyping tests for records added

[sgrekhov]

Please review files in LanguageFeatures/Subtyping/test_types/ folder. Files in this folder defines records types which then tested in different ways (as a return values, as a type arguments etc). Don't review all 100+ generated files

[eernstg]

Hi @sgrekhov, @chloestefantsova and I agreed to distribute the reviews based on odd/even numbers: I'll take the even ones, such as #1412.

[eernstg]

Checked a bunch of things, did not notice any serious issues. In some tests the top-level variable t1Instance is declared but never used, and some occurrences of forgetType seem to be unnecessary.

However, I'd need to take a look at the files used to generate all these libraries in order to see how all the small differences make sense. Where do I find those?

[sgrekhov]

@eernstg these generated files are produced from files in LanguageFeatures/Subtyping/test_types/. Here we define test types T0 and T1 and instance variables t0Instance and t1Instance.

Then test generator takes "test cases" defined in LanguageFeatures/Subtyping/dynamic/test_cases and LanguageFeatures/Subtyping/static/test_cases where types T0 and T1 are checked if T0 is subtype of T1 or not, using t0Instance and t1Instance. Generated tests arуe Cartesian product of these files

[eernstg]

OK, now I understand much better how this works: The libraries you mention ('LanguageFeatures/Subtyping/test_types/records_*.dart') are simply choosing the types to test, and then the generator generates a large number of code constructs where the given types are made subject to a subtype test (that occurs at compile time or at run time).

I haven't looked at the generator in detail, so this review will only be concerned with those basic libraries where the types are chosen.

They look fine, except that I suggested a few typo fixes in the @description. We might as well fix this now, to avoid having a large number of copies of those typos. ;-)

[eernstg]

Thanks! LGTM. Landing.