Skip to content

Fixes #2317. Add tests for extension type type parameters in non-covariant position #2318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2023

Conversation

sgrekhov
Copy link
Contributor

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit bc5ba37 into dart-lang:master Oct 25, 2023
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Oct 27, 2023
2023-10-25 [email protected] Fixes dart-lang/co19#2329. Fix FileSystemEntity.type() on Windows (dart-lang/co19#2332)
2023-10-25 [email protected] Fixes dart-lang/co19#2330. Remove obsolete error expectation (dart-lang/co19#2331)
2023-10-25 [email protected] Fixes dart-lang/co19#2317. Add tests for extension type type parameters in non-covariant position (dart-lang/co19#2318)
2023-10-25 [email protected] dart-lang/co19#2291. Update `Link.createSync()` according to the new documentation. Part 1 (dart-lang/co19#2305)
2023-10-24 [email protected] dart-lang/co19#2313. [Extension types] Add nullability tests (dart-lang/co19#2324)
2023-10-24 [email protected] dart-lang/co19#2323. Delete obsolete test (dart-lang/co19#2327)
2023-10-24 [email protected] Fixes dart-lang/co19#2323. Don't test datagram size more than 65503 (dart-lang/co19#2325)

Change-Id: I23b57a58b5cd6452e2beb923dd8cde6fd587f051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/332206
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
@sgrekhov sgrekhov deleted the co19-2317 branch January 10, 2024 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants