Skip to content

#3057. Add pattern assignment cases to for-in tests #3130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 3, 2025

Conversation

sgrekhov
Copy link
Contributor

@sgrekhov sgrekhov commented Apr 3, 2025

No description provided.

Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

It does look like a test will run and then incur a run time failure, though.

@sgrekhov sgrekhov requested a review from eernstg April 3, 2025 11:01
Copy link
Member

@eernstg eernstg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eernstg eernstg merged commit 2c7f9a6 into dart-lang:master Apr 3, 2025
2 checks passed
copybara-service bot pushed a commit to dart-lang/sdk that referenced this pull request Apr 4, 2025
2025-04-03 [email protected] dart-lang/co19#3057. Add pattern assignment cases to for-in tests (dart-lang/co19#3130)
2025-04-02 [email protected] dart-lang/co19#3057. Add pattern assignment cases to while-loop tests (dart-lang/co19#3127)
2025-04-02 [email protected] dart-lang/co19#3057. Add pattern assignment cases to do-while tests (dart-lang/co19#3124)
2025-04-02 [email protected] dart-lang/co19#3122. Fix typo in type_inference_A07_t01.dart (dart-lang/co19#3125)
2025-04-01 [email protected] dart-lang/co19#3122. Fix errors in dot shorthands tests. (dart-lang/co19#3123)
2025-04-01 [email protected] dart-lang/co19#3057. Add switch statement tests (dart-lang/co19#3121)
2025-03-31 [email protected] dart-lang/co19#3057. Fix tests for literals and the type-check (dart-lang/co19#3116)

Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try
Change-Id: Ieb1f5fb641976186bb0f5715c64e020c2ba097ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/420440
Reviewed-by: Alexander Thomas <[email protected]>
Reviewed-by: Erik Ernst <[email protected]>
Commit-Queue: Alexander Thomas <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants