-
Notifications
You must be signed in to change notification settings - Fork 28
#3057. Add return statement in loops tests #3158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Just a couple of comments about the ability (or not) of a return
statement to make something reachable.
Right. Thank you! Removed mentions of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2025-04-25 [email protected] dart-lang/co19#3122. Expect an error in case of non-constant in a constant expression (dart-lang/co19#3159) 2025-04-24 [email protected] dart-lang/co19#3057. Add return statement in loops tests (dart-lang/co19#3158) 2025-04-24 [email protected] dart-lang/co19#3057. Update instance check tests and add negated instance check ones (dart-lang/co19#3131) 2025-04-23 [email protected] dart-lang/co19#3057. Add promotion tests for C-style for-loop (dart-lang/co19#3153) 2025-04-18 [email protected] Fixes dart-lang/co19#3122. Update constants evaluation according to the specification (dart-lang/co19#3150) Cq-Include-Trybots: luci.dart.try:analyzer-linux-release-try Change-Id: Ie89c9a3fbb920cb7e6488d652118ccc805b6f4ad Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/424760 Commit-Queue: Erik Ernst <[email protected]> Reviewed-by: Alexander Thomas <[email protected]> Reviewed-by: Erik Ernst <[email protected]> Commit-Queue: Alexander Thomas <[email protected]>
No description provided.