Skip to content

Syntax highlighting of comments inside of a factory constructor. #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jwren opened this issue May 3, 2023 · 2 comments · Fixed by #46
Closed

Syntax highlighting of comments inside of a factory constructor. #45

jwren opened this issue May 3, 2023 · 2 comments · Fixed by #46

Comments

@jwren
Copy link
Member

jwren commented May 3, 2023

Syntax of commented out generics, inside of an factory constructor, see line 250:

Screenshot 2023-05-03 at 11 40 26 AM
@jwren
Copy link
Member Author

jwren commented May 3, 2023

@DanTup

DanTup added a commit to DanTup/dart-syntax-highlight that referenced this issue May 4, 2023
@DanTup
Add a test with comments inside type parameters/arguments
55d5243 
This records the current state for dart-lang#45, but doesn't fix it.
@DanTup DanTup mentioned this issue May 4, 2023
Merged
@DanTup
Copy link
Collaborator

DanTup commented May 4, 2023

Opened a PR at #46

@jwren jwren closed this as completed in #46 May 4, 2023
jwren pushed a commit that referenced this issue May 4, 2023
@DanTup
Fix highlighting of comments inside type args/parameters (#46)
4a321c4 
* Add a test with comments inside type parameters/arguments

This records the current state for #45, but doesn't fix it.

* Fix highlighting of comments inside type args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix highlighting of comments inside type args/parameters DanTup/dart-syntax-highlight
2 participants
@DanTup @jwren